[Buildroot] [PATCH 12 of 15] pkg-generic: add checks on deprecated variables FOO_BAR_OPT

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Thomas De Schampheleire,

On Sun, 5 Oct 2014 09:34:07 +0200, Thomas De Schampheleire wrote:

> >> > +$(eval $(call check-deprecated-variable,$(2)_MAKE_OPT,$(2)_MAKE_OPTS))
> >> > +$(eval $(call check-deprecated-variable,$(2)_INSTALL_OPT,$(2)_INSTALL_OPTS))
> >> > +$(eval $(call check-deprecated-variable,$(2)_INSTALL_TARGET_OPT,$(2)_INSTALL_TARGET_OPTS))
> >> > +$(eval $(call check-deprecated-variable,$(2)_INSTALL_STAGING_OPT,$(2)_INSTALL_STAGING_OPTS))
> >> > +$(eval $(call check-deprecated-variable,$(2)_INSTALL_HOST_OPT,$(2)_INSTALL_HOST_OPTS))
> >> > +$(eval $(call check-deprecated-variable,$(2)_CONF_OPT,$(2)_CONF_OPTS))
> 
> Such variables are used by several infras, like autotools and cmake.
> So moving them to one in particular is odd. Duplicating them would be
> equally undesirable.
> So in this case pkg-generic.mk seems the better place to me.

Hum, right, I didn't realize that.

> Moreover, even if only one specialized infra would use such a
> variable, generic packages sometimes use the same common names like
> FOO_MAKE_OPTS for variables, even though their name is really
> arbitrary.

Yes. Though it's kind of weird to "enforce" the non-usage of
<foo>_MAKE_OPT for generic-package, since such a variable is not
defined by the package infrastructure, and its naming left to the
choice of the package writer. But since we indeed want to see
<foo>_MAKE_OPTS being used instead, probably it makes sense.

> >> > +$(eval $(call check-deprecated-variable,$(2)_AUTORECONF_OPT,$(2)_AUTORECONF_OPTS))
> >> > +$(eval $(call check-deprecated-variable,$(2)_GETTEXTIZE_OPT,$(2)_GETTEXTIZE_OPTS))
> 
> This can be moved to pkg-autotools.mk, it makes more sense there.
> 
> >> > +$(eval $(call check-deprecated-variable,$(2)_BUILD_OPT,$(2)_BUILD_OPTS))
> 
> This variable serves basically the same function as FOO_MAKE_OPTS, but
> I guess it's not called '_MAKE_' because these infras (perl, python,
> ...) do not pass them to make.
> Since they are re-used in several ones I tend to place them in pkg-generic too.
> 
> >> > +$(eval $(call check-deprecated-variable,$(2)_KCONFIG_OPT,$(2)_KCONFIG_OPTS))
> 
> This can be moved to package/pkg-kconfig indeed.

Yeah, well, with this duplication thing, I'm no longer sure it's really
worth the effort. Maybe for clarity it's better to just duplicate what
needs to be duplicated, instead of having some variables handled in
each individual package infra, and some others at the pkg-generic level
even though they are specific to some package infrastructures?

No strong feeling here.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com