From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/libplist: fix python support
Date: Sun, 5 Oct 2014 12:08:43 +0200 [thread overview]
Message-ID: <20141005100843.GE4220@free.fr> (raw)
In-Reply-To: <1412502007-9902-2-git-send-email-s.martin49@gmail.com>
Samuel, All,
On 2014-10-05 11:40 +0200, Samuel Martin spake thusly:
> This patch:
> - fixes the python3 support detection in the libplist CMake code;
> - correctly sets the dependencies and configure options in libplist.mk.
Rather than trying to fix a 3-year old release (1.6), can't we have a look at
bumping to the latest release, 1.11, which is 'only' 6-month old?
I'll give it a spin.
Regards,
Yann E. MORIN.
> Fixes:
> http://autobuild.buildroot.net/results/efb/efba806b9a40a5e9c6bca7e591747ca2102fa1d5/
>
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> ...support-python2-and-python3-when-defining.patch | 27 ++++++++++++++++++++++
> package/libplist/libplist.mk | 13 +++++++++++
> 2 files changed, 40 insertions(+)
> create mode 100644 package/libplist/libplist-0003-cmake-swig-support-python2-and-python3-when-defining.patch
>
> diff --git a/package/libplist/libplist-0003-cmake-swig-support-python2-and-python3-when-defining.patch b/package/libplist/libplist-0003-cmake-swig-support-python2-and-python3-when-defining.patch
> new file mode 100644
> index 0000000..a5218e8
> --- /dev/null
> +++ b/package/libplist/libplist-0003-cmake-swig-support-python2-and-python3-when-defining.patch
> @@ -0,0 +1,27 @@
> +From 114d242a3b6b749b404cda80304e621556325d34 Mon Sep 17 00:00:00 2001
> +From: Samuel Martin <s.martin49@gmail.com>
> +Date: Sun, 5 Oct 2014 10:13:06 +0200
> +Subject: [PATCH] cmake: swig: support python2 and python3 when defining
> + DISTUTILS_PYTHON_ILIBRARY_PATH
> +
> +Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> +---
> + swig/CMakeLists.txt | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/swig/CMakeLists.txt b/swig/CMakeLists.txt
> +index 379cb95..ae6f0e7 100644
> +--- a/swig/CMakeLists.txt
> ++++ b/swig/CMakeLists.txt
> +@@ -9,7 +9,7 @@ SWIG_ADD_MODULE( plist python plist.i )
> + SWIG_LINK_LIBRARIES( plist plist plist++ ${PYTHON_LIBRARIES} )
> +
> + EXEC_PROGRAM("${PYTHON_EXECUTABLE}"
> +- ARGS "-c 'try:\n import distutils.sysconfig; print distutils.sysconfig.get_python_lib(plat_specific=1)\nexcept: pass\n'"
> ++ ARGS "-c 'from __future__ import print_function\ntry:\n import distutils.sysconfig; print(distutils.sysconfig.get_python_lib(plat_specific=1))\nexcept: pass\n'"
> + OUTPUT_VARIABLE DISTUTILS_PYTHON_ILIBRARY_PATH
> + )
> +
> +--
> +2.1.2
> +
> diff --git a/package/libplist/libplist.mk b/package/libplist/libplist.mk
> index 87f09c6..1e44fff 100644
> --- a/package/libplist/libplist.mk
> +++ b/package/libplist/libplist.mk
> @@ -12,4 +12,17 @@ LIBPLIST_MAKE = $(MAKE1)
> LIBPLIST_LICENSE = LGPLv2.1+
> LIBPLIST_LICENSE_FILES = COPYING
>
> +ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),y)
> +LIBPLIST_DEPENDENCIES += \
> + python$(if $(BR2_PACKAGE_PYTHON3),3) \
> + host-swig
> +LIBPLIST_CONF_OPTS += \
> + -DENABLE_PYTHON=ON \
> + -DSWIG_EXECUTABLE=$(SWIG)
> +else
> +LIBPLIST_CONF_OPTS += \
> + -DENABLE_PYTHON=OFF \
> + -DSWIG_EXECUTABLE=SWIG_EXECUTABLE-NOTFOUND
> +endif
> +
> $(eval $(cmake-package))
> --
> 2.1.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-05 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 9:40 [Buildroot] [PATCH 1/2] package/swig: define SWIG pointing to the host swig program Samuel Martin
2014-10-05 9:40 ` [Buildroot] [PATCH 2/2] package/libplist: fix python support Samuel Martin
2014-10-05 10:08 ` Yann E. MORIN [this message]
2014-10-05 12:08 ` Thomas Petazzoni
2014-10-05 10:09 ` [Buildroot] [PATCH 1/2] package/swig: define SWIG pointing to the host swig program Yann E. MORIN
2014-10-05 11:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141005100843.GE4220@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox