[Buildroot] [Patch v2 1/1] Fix selection of bootloaders from $(BR2_EXTERNAL)

[Eric Le Bihan <eric.le.bihan.dev@free.fr>]

On Wed, Oct 08, 2014 at 10:09:54AM +0200, Thomas Petazzoni wrote:
> Yann, Eric,
>
> On Wed, 8 Oct 2014 00:29:33 +0200, Yann E. MORIN wrote:
>
> > > To me, the $(BR2_EXTERNAL)/package directory should contain Makefiles for
> > > programs to be deployed in the rootfs of the target or host tools to build
> > > them. But a bootloader is not to be deployed on the rootfs, but to be built
> > > next to it. So it is more sensible to put the Makefile for a new/proprietary
> > > bootloader in $(BR2_EXTERNAL)/boot.
> >
> > I have to agree with Eric here: I think allowing (not enforcing) the
> > same layout in br2-external as in Buildroot is a good thing.
>
> Well, ok. So let's go with the patch, but maybe with an update to the
> manual?
>
> > > For $(BR2_EXTERNAL)/toolchain, a user may want to use a proprietary toolchain
> > > that is not available as a tarball and thus not installable via the
> > > traditional means.
> >
> > But does that even work at all?
> >
> > Toolchains are not packages; br2-external was not designed to get new
> > toolchain definitions. That it works, if it does at all, is just merely
> > happenstance.
> >
> > I wonder if/how we should/could get this to work.
>
> Clearly, that cannot work: how would one re-use the external toolchain
> logic to copy the sysroot, the target libraries and so on. Plus, the
> existing external toolchain mechanism already allows to use the tarball
> of a toolchain.

So, it would be best to remove the toolchain part of the patch, keeping only
the bootloader one. I'll add a comment about it in
docs/manual/customize-outside-br.txt and send a new version of the patch.

Best regards,
ELB