From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Fri, 10 Oct 2014 13:01:14 +0200 Subject: [Buildroot] [PATCH 1/2] automake: update gtk-doc.m4 to serial 2 In-Reply-To: <5437B8B3.7070105@zacarias.com.ar> References: <1412936897-8478-1-git-send-email-gustavo@zacarias.com.ar> <20141010124101.0388b2b3@free-electrons.com> <5437B8B3.7070105@zacarias.com.ar> Message-ID: <20141010130114.71fd0a73@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Gustavo Zacarias, On Fri, 10 Oct 2014 07:45:07 -0300, Gustavo Zacarias wrote: > > I'm not sure exactly, but shouldn't depending on host-pkgconf be the > > responsibility of each individual package that uses the gtk-doc.m4 > > stuff? > > > > Even though I agree pkgconf is fairly quick to build, I find it odd to > > have host-automake depend on host-pkgconf if it's only a very limited > > number of packages that actually use the gtk-doc.m4 stuff that need the > > host-pkgconf dependency. > > The problem is it wasn't the case for gtk-doc.m4 serial 1, the check and > need for pkgconfig is done after gtk-doc is enabled, but for serial 2 > some of the checks are done before that. > So we'd need to find all packages that use gtk-doc.m4 and add it there > (well, for those that autoreconf, but that would be sloppy since an > added autoreconf would trigger the need). Yes, correct, that's my idea. I think it's more correct than globally adding this host-pkgconf dependency. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com