From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] scripts/graph-build-time: clarify backend selection
Date: Sun, 12 Oct 2014 12:57:33 +0200 [thread overview]
Message-ID: <20141012105733.GC3870@free.fr> (raw)
In-Reply-To: <1413111142-17643-1-git-send-email-luca@lucaceresoli.net>
Luca, All,
On 2014-10-12 12:52 +0200, Luca Ceresoli spake thusly:
> This instruction in the middle of 'import' lines looks very strange.
>
> Also, it was not obvious to me what the 'Agg' backend is.
>
> Both things are actually correct, but it took a while to find out why.
> So clarify with a comment to save someone else's time.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> Cc: Sascha Arthur <sascha.arthur@gmail.com>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
Except for a little typo:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> support/scripts/graph-build-time | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/support/scripts/graph-build-time b/support/scripts/graph-build-time
> index 4bb90c2..b2817bd 100755
> --- a/support/scripts/graph-build-time
> +++ b/support/scripts/graph-build-time
> @@ -52,7 +52,12 @@
> import matplotlib as mpl
> import numpy
>
> +# Use the Agg backend (which produces a PNG output, see
> +# http://matplotlib.org/faq/usage_faq.html#what-is-a-backend),
> +# otherwise an incorrect backend is used on soe host machines).
s/soe/smoe/
Regards,
Yann E. MORIN.
> +# Note: matplotlib.use() must be called *before* matplotlib.pyplot.
> mpl.use('Agg')
> +
> import matplotlib.pyplot as plt
> import matplotlib.font_manager as fm
> import csv
> --
> 1.9.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-12 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 10:52 [Buildroot] [PATCH 1/2] scripts/graph-build-time: clarify backend selection Luca Ceresoli
2014-10-12 10:52 ` [Buildroot] [PATCH 2/2] scripts/graph-build-time: properly warn about missing modules Luca Ceresoli
2014-10-12 15:23 ` Peter Korsgaard
2014-10-12 10:57 ` Yann E. MORIN [this message]
2014-10-12 11:58 ` [Buildroot] [PATCH 1/2] scripts/graph-build-time: clarify backend selection Thomas De Schampheleire
2014-10-12 15:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141012105733.GC3870@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox