From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/2] pkg-infra: make timing of steps optional
Date: Sun, 12 Oct 2014 11:37:59 +0200 [thread overview]
Message-ID: <20141012113759.7e73f645@free-electrons.com> (raw)
In-Reply-To: <1410744672-32698-2-git-send-email-danomimanchego123@gmail.com>
Dear Danomi Manchego,
On Sun, 14 Sep 2014 21:31:12 -0400, Danomi Manchego wrote:
> Commit 17d4eb1e0261793a9f89e4a2253602c7ab926d2e added a hook to log timing
> of steps to a build-time.log file, which provides data for the "graph-build"
> target for examining build time stats. If one uses buildroot on a daily
> basis as part of a build system, then its conceivable that there might be
> long periods of time between "make clean" ops. So the log file continues
> to grow. This patch makes the accumulation of the timing data optional, to
> avoid having a silent endlessly growing log in the build directory.
>
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
We had some discussion at the Buildroot meeting today about this patch,
and the general opinion is the one already expressed by Yann. The
amount of data accumulated in this build-time.log file is very small,
so even if you do repeated builds without make clean for several days,
the file size will remain really small compared to the overall size of
a standard Buildroot build tree. Therefore, we don't think adding yet
another configuration option for this is really useful, and
consequently we have marked your patch as Rejected in patchwork.
Thanks,
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-12 9:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 1:31 [Buildroot] [PATCH v2 1/2] pkg-infra: put optional step_user def and assignment in one block Danomi Manchego
2014-09-15 1:31 ` [Buildroot] [PATCH v2 2/2] pkg-infra: make timing of steps optional Danomi Manchego
2014-09-21 22:13 ` Yann E. MORIN
2014-09-22 2:18 ` Danomi Manchego
2014-09-22 17:17 ` Yann E. MORIN
2014-10-12 9:37 ` Thomas Petazzoni [this message]
2014-09-21 20:57 ` [Buildroot] [PATCH v2 1/2] pkg-infra: put optional step_user def and assignment in one block Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141012113759.7e73f645@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox