Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/mono: new package
Date: Sun, 12 Oct 2014 11:45:19 +0200	[thread overview]
Message-ID: <20141012114519.30aa9822@free-electrons.com> (raw)
In-Reply-To: <CA+TH9V=5MVzboiyLDxuuJwXJ=v-t9eZ-8kPF0q=AhXtDsS-1Rg@mail.gmail.com>

Dear Angelo Compagnucci,

On Sun, 12 Oct 2014 11:21:20 +0200, Angelo Compagnucci wrote:

> > Then, the conditional shouldn't be here, but around the dependency of
> > mono on host-mono.
> >
> > That being said, I would recommend you to keep things simple for now,
> > and handle only this use case as a follow-up contribution.
> 
> It is already:
> 
> ifneq ($(MONO_ASSEMBLY_INCLUDED),)
> define MONO_INSTALL_LIBS
> rsync -av --exclude=*.so --exclude=*.mdb --exclude=[0-9].[0-9] \
> $(HOST_DIR)/usr/lib/mono $(TARGET_DIR)/usr/lib/
> rsync -av --exclude=*.so --exclude=*.mdb $(MONO_ASSEMBLY_INCLUDED) \
> $(TARGET_DIR)/usr/lib/mono/
> endef
> MONO_DEPENDENCIES += host-mono
> MONO_POST_INSTALL_TARGET_HOOKS += MONO_INSTALL_LIBS
> endif
> 
> This way the dependency is met only when MONO_ASSEMBLY_INCLUDED.
> By the way, I'll remove this logic, make 4.5 as default version and if
> nothing selected, I'll default evenly on 4.5.

Ok, right. Then don't add a condition around the host-autotools-package
call, this is useless.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-10-12  9:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-12  7:50 [Buildroot] Mono: new package Angelo Compagnucci
2014-10-12  7:50 ` [Buildroot] [PATCH 1/2] package/monolite: " Angelo Compagnucci
2014-10-12  7:50 ` [Buildroot] [PATCH 2/2] package/mono: " Angelo Compagnucci
2014-10-12  8:25   ` Thomas Petazzoni
2014-10-12  8:44     ` Angelo Compagnucci
2014-10-12  9:02       ` Thomas Petazzoni
2014-10-12  9:21         ` Angelo Compagnucci
2014-10-12  9:45           ` Thomas Petazzoni [this message]
2014-10-12 10:06             ` Angelo Compagnucci
2014-10-12 12:56               ` Thomas Petazzoni
2014-10-12  8:59     ` Angelo Compagnucci
2014-10-12  9:44       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141012114519.30aa9822@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox