Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB
Date: Sun, 12 Oct 2014 18:51:16 +0200	[thread overview]
Message-ID: <20141012185116.2f24af40@free-electrons.com> (raw)
In-Reply-To: <1413131685-5567-2-git-send-email-abrodkin@synopsys.com>

Dear Alexey Brodkin,

On Sun, 12 Oct 2014 18:34:44 +0200, Alexey Brodkin wrote:

> diff --git a/Config.in b/Config.in
> index 24aa883..66cea4a 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -536,15 +536,18 @@ comment "enabling Stack Smashing Protection requires support in the toolchain"
>  	depends on !BR2_TOOLCHAIN_HAS_SSP
>  
>  config BR2_PREFER_STATIC_LIB
> -	bool "prefer static libraries"
> +	bool "build statically linked applications, no dynamic libraries"
>  	help
> -	  Where possible, build and use static libraries for the target.
> -	  This potentially increases your code size and should only be
> +	  Build all application for the target statically linked.
> +	  This potentially increases your filesystem size and should only be
>  	  used if you know what you do.
> -	  The default is to build dynamic libraries and use those on
> -	  the target filesystem.
>  
> -	  WARNING: This is highly experimental at the moment.
> +	  Note that some applications cannot be build statically and so are
> +	  intentionally disabled.
> +
> +	  The default is to build dynamic libraries and dynamically linked
> +	  applications to use those on the target filesystem.

"The default" should be clarified as "When this option is disabled".

Also linked -> link.

With this fixed (probably Peter can fix this when applying):

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-10-12 16:51 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-12 16:34 [Buildroot] [PATCH 0/2] infra: BR2_PREFER_STATIC_LIB now selects static building of packages Alexey Brodkin
2014-10-12 16:34 ` [Buildroot] [PATCH 1/2] Config.in: update description of BR2_PREFER_STATIC_LIB Alexey Brodkin
2014-10-12 16:51   ` Thomas Petazzoni [this message]
2014-10-12 17:22     ` Yann E. MORIN
2014-10-12 22:17   ` Peter Korsgaard
2014-10-12 16:34 ` [Buildroot] [PATCH 2/2] uclibc: explicitly set HAVE_SHARED depending on BR2_PREFER_STATIC_LIB Alexey Brodkin
2014-10-12 16:52   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141012185116.2f24af40@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox