From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: add --delete to rsync
Date: Sun, 12 Oct 2014 18:55:07 +0200 [thread overview]
Message-ID: <20141012185507.3bfb8f72@free-electrons.com> (raw)
In-Reply-To: <CAM+bi4sERYCa0rsUgskkEOtO_EKLHGsJvkYC+d54hgH-xbue9Q@mail.gmail.com>
Dear Alvaro Gamez,
On Sun, 12 Oct 2014 18:37:28 +0200, Alvaro Gamez wrote:
> Although it's true that something like gcc *.c isn't very elegant, I
> can't agree on being the build system broken.
Well, I guess it's a matter of definition of the word 'broken' :-)
> After all, if you start
> adding and removing files from the source code, the expectation should
> be that the next build is going to be different from the previous one.
> Nevertheless, if this hasn't come to attention before it's probably a
> non problem (I saw this happen on a custom package that isn't even a
> real package, just fiddling around and making tests), so I understand
> the reject.
>
> The only solution I can think of that satisfies both conditions (fast
> builds and identical tree) is something like saving (where?) the
> output of `find $(X_OVERRIDE_SRCDIR)` before rsyncing for the first
> time, and after rsyncing for the second time remove files listed on
> the saved list from before previous to doing the next rsync.
>
> Do you have any opinion on this idea? Admittedly, it seems ugly.
You can experiment with that if you wish, but it indeed doesn't seem
very pretty, so I'm not sure we will be willing to merge something like
this.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-10-12 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 9:14 [Buildroot] [PATCH 1/1] package/pkg-generic.mk: add --delete to rsync Alvaro G. M
2014-10-10 10:36 ` Thomas Petazzoni
2014-10-10 10:45 ` Alvaro Gamez
2014-10-10 13:33 ` Thomas Petazzoni
2014-10-12 16:26 ` Thomas Petazzoni
2014-10-12 16:37 ` Alvaro Gamez
2014-10-12 16:55 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141012185507.3bfb8f72@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox