[Buildroot] [PATCH] spidev_test: new package

[Baruch Siach <baruch@tkos.co.il>]

Hi Thomas,

On Tue, Oct 14, 2014 at 10:14:57PM +0200, Thomas De Schampheleire wrote:
> Baruch Siach <baruch@tkos.co.il> schreef:
> >On Tue, Oct 14, 2014 at 12:45:53PM -0300, Gustavo Zacarias wrote:
> >> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> >
> >[snip]
> >
> >> diff --git a/package/spidev_test/Config.in b/package/spidev_test/Config.in
> >> new file mode 100644
> >> index 0000000..c0ed9ef
> >> --- /dev/null
> >> +++ b/package/spidev_test/Config.in
> >> @@ -0,0 +1,15 @@
> >> +config BR2_PACKAGE_SPIDEV_TEST
> >> +	bool "spidev_test"
> >> +	depends on BR2_LINUX_KERNEL
> >
> >That is a heavy dependency. As you noted in another message, it also make the 
> >autobuilder skip this package. I suggest to download just spidev_test.c from 
> >http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/plain/Documentation/spi/spidev_test.c?id=$(SPIDEV_TEST_VERSION), 
> >and make it depend on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15 (as of v3.17). This 
> >solves both the autobuilder issue, and the toolchain headers dependency.
> 
> From where comes this dependency on 3.15/3.17?

Linux kernel commit c2e78c34ef0 (spi: spidev_test: Add support for Dual/Quad 
SPI Transfers) added a build dependency on SPI_IOC_{RD,WR}_MODE32 which is 
only available since v3.15.

> The test program was in the kernel for a very long time (2.6.x)...
> 
> Also, what is the autobuilder issue you are talking about?

A dependency on BR2_LINUX_KERNEL means that the autobuilder won't build this 
package, since the autobuilder does not build kernels, and so never enables 
BR2_LINUX_KERNEL.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -