From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] squidguard: new package
Date: Fri, 17 Oct 2014 23:10:33 +0200 [thread overview]
Message-ID: <20141017211033.GG3971@free.fr> (raw)
In-Reply-To: <543F9CBD.2010705@oliseo.fr>
Guillaume, All,
On 2014-10-16 12:23 +0200, Guillaume GARDET - Olis?o spake thusly:
> Le 10/10/2014 23:51, Peter Korsgaard a ?crit :
> >>>>>>"Guillaume" == Guillaume GARDET <guillaume.gardet@oliseo.fr> writes:
[--SNIP--]
> > > diff --git a/package/squidguard/Config.in b/package/squidguard/Config.in
> > > new file mode 100644
> > > index 0000000..8d3c28e
> > > --- /dev/null
> > > +++ b/package/squidguard/Config.in
> > > @@ -0,0 +1,24 @@
> > > +comment "squidguards needs Squid"
> > > + depends on !BR2_PACKAGE_SQUID
> >
> >squid should not be capitalized. I don't know much about squid and these
> >plugins, but would anybody needing this NOT enable squid just above
> >already? Perhaps the comment isn't really needed?
>
> I think it is better to keep it but if you think I should remove it, I will. Just tell me.
I side with Peter here. Squid is an obvious dependency of squidguard, so
the comment is not needed.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-17 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 20:38 [Buildroot] [PATCH] squidguard: new package Guillaume GARDET
2014-10-10 21:51 ` Peter Korsgaard
2014-10-16 10:23 ` Guillaume GARDET - Oliséo
2014-10-17 21:10 ` Yann E. MORIN [this message]
2015-07-02 9:50 ` [Buildroot] [PATCH V2] " Guillaume GARDET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017211033.GG3971@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox