From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 2/3] gst-ffmpeg: add --pkg-config to internal libav configure options
Date: Fri, 17 Oct 2014 23:24:53 +0200 [thread overview]
Message-ID: <20141017212453.GI3971@free.fr> (raw)
In-Reply-To: <1413142206-30581-2-git-send-email-danomimanchego123@gmail.com>
Danomi, All,
On 2014-10-12 15:30 -0400, Danomi Manchego spake thusly:
> The internal copy of libav in gst-ffmpeg does not understand the
> PKG_CONFIG env variable, so it throws a line like this at the end
> of its configuration:
>
> WARNING: .../output/host/usr/bin/i686-pc-linux-gnu-pkg-config not found, library detection may fail.
Instead of fixing just that one package, shouldn't we provide a symlink:
TUPLE-pkg-config -> pkg-config
This way, all packages that expect a cross-pkg-config will work without
customisation.
Thomas, thoughts?
Regards,
Yann E. MORIN.
> This patch adds the --pkg-config to let libav know where it is.
>
> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
>
> ---
>
> This is basically the same problem suffered by ffmpeg, fixed in
> commit a9a5a8159937cbc5e472cbd0b144d596b85a3386.
> ---
> package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk b/package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk
> index af3e880..11f28dc 100644
> --- a/package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk
> +++ b/package/gstreamer/gst-ffmpeg/gst-ffmpeg.mk
> @@ -22,7 +22,8 @@ endif
>
> GST_FFMPEG_CONF_EXTRA_OPTS = \
> --cross-prefix=$(TARGET_CROSS) \
> - --target-os=linux
> + --target-os=linux \
> + --pkg-config='$(PKG_CONFIG_HOST_BINARY)'
>
> ifeq ($(BR2_PACKAGE_ZLIB),y)
> GST_FFMPEG_CONF_EXTRA_OPTS += --enable-zlib
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-17 21:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 19:30 [Buildroot] [PATCH v3 1/3] gst-ffmpeg: add option to select GPL vs LGPL build Danomi Manchego
2014-10-12 19:30 ` [Buildroot] [PATCH v3 2/3] gst-ffmpeg: add --pkg-config to internal libav configure options Danomi Manchego
2014-10-13 13:37 ` Luca Ceresoli
2014-10-13 16:26 ` Danomi Manchego
2014-10-14 8:59 ` Luca Ceresoli
2014-10-17 21:24 ` Yann E. MORIN [this message]
2014-10-17 21:39 ` Bernd Kuhls
2014-10-17 22:46 ` Yann E. MORIN
2014-10-18 11:51 ` Thomas Petazzoni
2014-10-18 13:14 ` Arnout Vandecappelle
2014-10-12 19:30 ` [Buildroot] [PATCH v3 3/3] gst-ffmpeg: expand package description to describe libav usage Danomi Manchego
2014-10-13 12:15 ` Luca Ceresoli
2014-10-13 12:16 ` [Buildroot] [PATCH v3 1/3] gst-ffmpeg: add option to select GPL vs LGPL build Luca Ceresoli
2014-10-17 21:32 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141017212453.GI3971@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox