From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yann E. MORIN Date: Sat, 18 Oct 2014 23:57:48 +0200 Subject: [Buildroot] [PATCH v2] modplugtools: Added package In-Reply-To: <1413662640-16030-1-git-send-email-maarten@treewalker.org> References: <1413602358-7476-1-git-send-email-maarten@treewalker.org> <1413662640-16030-1-git-send-email-maarten@treewalker.org> Message-ID: <20141018215748.GF31723@free.fr> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Maarten, All, On 2014-10-18 22:04 +0200, Maarten ter Huurne spake thusly: > This installs the 'modplug123' command line tool to play tracker music > files (MOD, S3M, XM etc.) using libmodplug. > > http://modplug-xmms.sourceforge.net/ > > Signed-off-by: Maarten ter Huurne [--SNIP--] > diff --git a/package/modplugtools/Config.in b/package/modplugtools/Config.in > new file mode 100644 > index 0000000..20009b6 > --- /dev/null > +++ b/package/modplugtools/Config.in > @@ -0,0 +1,9 @@ > +config BR2_PACKAGE_MODPLUGTOOLS > + bool "modplugtools" > + select BR2_PACKAGE_LIBAO > + select BR2_PACKAGE_LIBMODPLUG modplugtools should inherit the dependencies from libmodplug, namely C++: config BR2_PACKAGE_MODPLUGTOOLS bool "modplugtools" depends on BR2_INSTALL_LIBSTDCPP # libmodplug select BR2_PACKAGE_LIBMODPLUG select BR2_PACKAGE_LIBAO > + help > + This installs the 'modplug123' command line tool to play tracker music > + files (MOD, S3M, XM etc.) using libmodplug. Since the comments in the .mk file are not directly visible to the user, it would be nice to put a little blurb about OSS vs. ALSA, something like: modplugplay uses libao to play MOD files, so can output via either ALSA or OSS. > + http://modplug-xmms.sourceforge.net/ > diff --git a/package/modplugtools/modplugtools.mk b/package/modplugtools/modplugtools.mk > new file mode 100644 > index 0000000..186d4a7 > --- /dev/null > +++ b/package/modplugtools/modplugtools.mk > @@ -0,0 +1,23 @@ > +################################################################################ > +# > +# modplugtools > +# > +################################################################################ > + > +MODPLUGTOOLS_VERSION = 0.5.3 > +MODPLUGTOOLS_SITE = http://downloads.sourceforge.net/project/modplug-xmms/modplug-tools > +MODPLUGTOOLS_LICENSE = GPLv3 > +MODPLUGTOOLS_LICENSE_FILES = COPYING > + > +MODPLUGTOOLS_DEPENDENCIES = libao libmodplug > + > +# The modplugtools package can build two players: modplugplay that plays > +# directly via OSS and modplug123 that plays via libao. Since modplugplay > +# won't work without OSS support and modern kernels are likely to have no > +# OSS or OSS emulation, we build only modplug123. > +# If you have a system without ALSA support for some reason, you can still > +# use modplug123 to play over OSS via libao. This comment should instead be part of the commit log, and a simpler comment should be added instead here: # Only build the mp123 subdir, which contains 'modplug123', since # we do not want to build 'modplugplay', as it requires legacy OSS # and 'modplug123' can output via either ALSA or OSS. Also, if the options of modplugplay and modplug123 are the same, then you could just install a symlink modplugplay -> modplug123 . Regards, Yann E. MORIN. > +MODPLUGTOOLS_MAKE_OPTS = SUBDIRS=mp123 > +MODPLUGTOOLS_INSTALL_TARGET_OPTS = SUBDIRS=mp123 DESTDIR=$(TARGET_DIR) install > + > +$(eval $(autotools-package)) > -- > 1.8.4.5 > -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'