From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] bandwidthd: Version bump to handle indirect deps properly
Date: Sun, 19 Oct 2014 12:19:41 +0200 [thread overview]
Message-ID: <20141019101941.GN4072@free.fr> (raw)
In-Reply-To: <54438B78.1070805@gmail.com>
Nathaniel, All,
On 2014-10-19 17:59 +0800, Nathaniel Roach spake thusly:
> On 19/10/14 17:41, Yann E. MORIN wrote:
> > Nathaniel, All,
> >
> > On 2014-10-19 16:55 +0800, Nathaniel Roach spake thusly:
> >> Thanks to Romain Naor, Baruch Siach and Thomas Petazzoni, I've
> >
> > Romain Naour, I believe... ;-)
>
> Damn it...
>
> >
> >> solved the build issues in certain cases for bandwidthd.
> >>
> >> The issue was that libpcap and libpng would depend on other libraries
> >> and upon testing for pcap/libpng the tests would fail due to not
> >> being able to find the other libraries.
> >>
> >> Bandwidthd's configure script now uses pkg-config for libpng
> >> and pcap-config for libpcap. pcap-config's path is specified
> >> in configure's arguments.
> >>
> >> Some other tweaks have been made including the layout and flow
> >> of configure.ac is a bit more logical, and the handling of postgres
> >> and sqlite has been tweaked. Finally, the test for X.Org has been
> >> removed.
> >>
> >> Fixes: http://autobuild.buildroot.org/results/eb4/eb48acec37a7fd1714b267b105816bf0053d40e9/build-end.log
> >> Signed-off-by: Nathaniel Roach <nroach44@gmail.com>
> >
> > Usually, when some people helped with the patch, it is customary (but
> > not mandatory) to add them in Cc: lines below the SoB line. ;-)
> >
> > Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > Regards,
> > Yann E. MORIN.
> >
>
> I'll send a fixed one through shortly.
No need I guess, the typo can be fixed by whoever applies the patch.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2014-10-19 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 8:55 [Buildroot] [PATCH 1/1] bandwidthd: Version bump to handle indirect deps properly Nathaniel Roach
2014-10-19 9:41 ` Yann E. MORIN
2014-10-19 9:59 ` Nathaniel Roach
2014-10-19 10:19 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019101941.GN4072@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox