Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] modplugtools: Added package
Date: Sun, 19 Oct 2014 11:41:37 +0200	[thread overview]
Message-ID: <20141019114137.1f0e8d09@free-electrons.com> (raw)
In-Reply-To: <1413676846-23424-1-git-send-email-maarten@treewalker.org>

Dear Maarten ter Huurne,

On Sun, 19 Oct 2014 02:00:46 +0200, Maarten ter Huurne wrote:
> This installs the 'modplug123' command line tool to play tracker music
> files (MOD, S3M, XM etc.) using libmodplug.
> 
> The modplugtools package can build two players: modplugplay that plays
> directly via OSS and modplug123 that plays via libao. Since modplugplay
> won't work without OSS support and modern kernels are likely to have no
> OSS or OSS emulation, we build only modplug123.
> 
> If you have a system without ALSA support for some reason, you can
> still use modplug123 to play over OSS via libao.
> 
> http://modplug-xmms.sourceforge.net/
> 
> Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>

Thanks, applied. But there was one missing that Yann didn't spot (!),
see below:

> diff --git a/package/modplugtools/Config.in b/package/modplugtools/Config.in
> new file mode 100644
> index 0000000..386bae9
> --- /dev/null
> +++ b/package/modplugtools/Config.in
> @@ -0,0 +1,11 @@
> +config BR2_PACKAGE_MODPLUGTOOLS
> +	bool "modplugtools"
> +	depends on BR2_INSTALL_LIBSTDCPP # libmodplug
> +	select BR2_PACKAGE_LIBAO
> +	select BR2_PACKAGE_LIBMODPLUG
> +	help
> +	  This installs the 'modplug123' command line tool to play music files
> +	  in the tracker formats supported by libmodplug: MOD, S3M, XM etc.
> +	  Audio output is handled by libao.
> +
> +	  http://modplug-xmms.sourceforge.net/

Since you depend on C++, there should be a comment here about this
dependency. I've added it and applied your patch.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-10-19  9:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-18  3:19 [Buildroot] [PATCH] sdl_mixer: Enable support for libmodplug Maarten ter Huurne
2014-10-18 13:42 ` Arnout Vandecappelle
2014-10-18 20:04 ` [Buildroot] [PATCH v2] modplugtools: Added package Maarten ter Huurne
2014-10-18 21:57   ` Yann E. MORIN
2014-10-18 23:28     ` Maarten ter Huurne
2014-10-19  9:11       ` Yann E. MORIN
2014-10-19  0:00   ` [Buildroot] [PATCH v3] " Maarten ter Huurne
2014-10-19  9:25     ` Yann E. MORIN
2014-10-19  9:41     ` Thomas Petazzoni [this message]
2014-10-19 10:22 ` [Buildroot] [PATCH] sdl_mixer: Enable support for libmodplug Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141019114137.1f0e8d09@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox