Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] yaml-cpp: new package
Date: Sun, 19 Oct 2014 17:11:16 +0200	[thread overview]
Message-ID: <20141019151116.GV4072@free.fr> (raw)
In-Reply-To: <1413470910-8412-1-git-send-email-sebastien.bourdelin@savoirfairelinux.com>

Sebastien, All,

On 2014-10-16 10:48 -0400, Sebastien Bourdelin spake thusly:
> yaml-cpp is a YAML parser and emitter in C++ matching
> the YAML 1.2 spec.
> 
> https://code.google.com/p/yaml-cpp/
> 
> Signed-off-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
[--SNIP--]
> diff --git a/package/yaml-cpp/Config.in b/package/yaml-cpp/Config.in
> new file mode 100644
> index 0000000..fcfd60f
> --- /dev/null
> +++ b/package/yaml-cpp/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_YAML_CPP
> +	bool "yaml-cpp"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_LARGEFILE
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
> +	select BR2_PACKAGE_BOOST

Are BR2_LARGEFILE and BR2_TOOLCHAIN_HAS_THREADS hard dependencies of
yaml-cpp, or are they inherited from boost?

In the latter case, it should be documented, like so:

    depends on BR2_LARGEFILE # boost
    depends on BR2_TOOLCHAIN_HAS_THREADS # boost

> +	help
> +	  yaml-cpp is a YAML parser and emitter in C++ matching
> +	  the YAML 1.2 spec.
> +
> +	  https://code.google.com/p/yaml-cpp/
> +
> +comment "yaml-cpp needs a toolchain w/ C++, largefile, threads"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/yaml-cpp/yaml-cpp.hash b/package/yaml-cpp/yaml-cpp.hash
> new file mode 100644
> index 0000000..391e317
> --- /dev/null
> +++ b/package/yaml-cpp/yaml-cpp.hash
> @@ -0,0 +1,5 @@
> +# hash from: https://yaml-cpp.googlecode.com/files/yaml-cpp-0.5.1.tar.gz:
> +sha1 9c5414b4090491e96d1b808fe8628b31e625fdaa  yaml-cpp-0.5.1.tar.gz
> +
> +# Locally calculated:
> +sha256 3e7c9052b43d987d41819a203d97fc45de4eed3ec67e0fdb14265c3d11046f06  yaml-cpp-0.5.1.tar.gz
> diff --git a/package/yaml-cpp/yaml-cpp.mk b/package/yaml-cpp/yaml-cpp.mk

Both hash locally and manually verified.

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> new file mode 100644
> index 0000000..5ebdb23
> --- /dev/null
> +++ b/package/yaml-cpp/yaml-cpp.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# yaml-cpp
> +#
> +################################################################################
> +
> +YAML_CPP_VERSION = 0.5.1
> +YAML_CPP_SITE = https://yaml-cpp.googlecode.com/files
> +YAML_CPP_INSTALL_STAGING = YES
> +YAML_CPP_LICENSE = MIT
> +YAML_CPP_LICENSE_FILES = license.txt
> +
> +$(eval $(cmake-package))
> -- 
> 1.8.3.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20141019/a182decd/attachment.asc>

  reply	other threads:[~2014-10-19 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-16 14:48 [Buildroot] [PATCH v2] yaml-cpp: new package Sebastien Bourdelin
2014-10-19 15:11 ` Yann E. MORIN [this message]
2014-10-20 14:57   ` Sebastien Bourdelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141019151116.GV4072@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox