From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] infra: Move --enable/--disable-debug to package/Makefile.in
Date: Sun, 19 Oct 2014 17:15:12 +0200 [thread overview]
Message-ID: <20141019151512.GW4072@free.fr> (raw)
In-Reply-To: <20141019170930.6cfe86d0@free-electrons.com>
Thomas, All,
On 2014-10-19 17:09 +0200, Thomas Petazzoni spake thusly:
> On Sun, 19 Oct 2014 11:59:01 +0200, Bernd Kuhls wrote:
> > A lot of packages ignored BR2_ENABLE_DEBUG. This patch simplifies the handling of
> > this option by adding the corresponding configure option to the global Makefile
> > for target packages.
> >
> > For host packages --disable-debug is added to the global Makefile.
> >
> > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
>
> Patches 1 and 2 applied. For patch 3, I'm a bit hesitant: there are
> only two packages using --disable-gtk-doc-html. Does it really make
> sense to factorize that in the package infrastructure?
>
> Cc'ing Yann to get his input, since he Reviewed-by the patc in question.
Well, my Reviewed-by means just that: I reviewed it, and found it was
correct. It does not mean I think it should go in.
However, I do believe it should go in. The more generic stuff we move
into the infra, the easier it will get to review packages.
And since we already have four documentation-rleated switches, it makes
sense to add another one. Further more, we do have --disable-gtk-doc, so
adding --disable-gtk-doc-html really makes sense, for consistency.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-19 15:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 9:59 [Buildroot] [PATCH v2 1/3] infra: Move --enable/--disable-debug to package/Makefile.in Bernd Kuhls
2014-10-19 9:59 ` [Buildroot] [PATCH v2 2/3] Remove --disable-gtk-doc from packages, already defined in pkg-autotools.mk Bernd Kuhls
2014-10-19 10:23 ` Yann E. MORIN
2014-10-19 9:59 ` [Buildroot] [PATCH v2 3/3] Apply --disable-gtk-doc-html to all packages Bernd Kuhls
2014-10-19 10:23 ` Yann E. MORIN
2015-02-03 14:25 ` Thomas Petazzoni
2014-10-19 10:23 ` [Buildroot] [PATCH v2 1/3] infra: Move --enable/--disable-debug to package/Makefile.in Yann E. MORIN
2014-10-19 15:09 ` Thomas Petazzoni
2014-10-19 15:15 ` Yann E. MORIN [this message]
2014-10-19 15:19 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141019151512.GW4072@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox