Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/liblog4c-localtime: Fix build with BR2_ENABLE_DEBUG=yes
Date: Sun, 19 Oct 2014 22:49:55 +0200	[thread overview]
Message-ID: <20141019224955.172648e4@free-electrons.com> (raw)
In-Reply-To: <1413748165-2732-2-git-send-email-bernd.kuhls@t-online.de>

Dear Bernd Kuhls,

On Sun, 19 Oct 2014 21:49:25 +0200, Bernd Kuhls wrote:

> diff --git a/package/liblog4c-localtime/liblog4c-0003-debug.patch b/package/liblog4c-localtime/liblog4c-0003-debug.patch
> new file mode 100644
> index 0000000..80b00cf
> --- /dev/null
> +++ b/package/liblog4c-localtime/liblog4c-0003-debug.patch
> @@ -0,0 +1,37 @@
> +Fix build with BR2_ENABLE_DEBUG=yes
> +
> +Fixes
> +init.c:39:20: fatal error: mcheck.h: No such file or directory
> +
> +Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

Same comment as for the other package: using
AC_CHECK_HEADER([mcheck.h]) and then HAVE_MCHECK_H is a much better
solution.

Do you think you can push upstream this patch as well as the other
patches that we have?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-10-19 20:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-19 19:49 [Buildroot] [PATCH 1/2] package/liblog4c-localtime: use numbered patches Bernd Kuhls
2014-10-19 19:49 ` [Buildroot] [PATCH 2/2] package/liblog4c-localtime: Fix build with BR2_ENABLE_DEBUG=yes Bernd Kuhls
2014-10-19 20:49   ` Thomas Petazzoni [this message]
2014-10-26 11:37     ` Thomas Petazzoni
2014-10-19 20:50 ` [Buildroot] [PATCH 1/2] package/liblog4c-localtime: use numbered patches Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141019224955.172648e4@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox