From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric =?ISO-8859-1?B?QuluYXJk?= <eric@eukrea.com>
Date: Mon, 20 Oct 2014 10:31:31 +0200
Subject: [Buildroot] [PATCH 1/2] mx53loco: update support
In-Reply-To: <8738ajcgnf.fsf@dell.be.48ers.dk>
References: <1413790693-8281-1-git-send-email-eric@eukrea.com>
 <8738ajcgnf.fsf@dell.be.48ers.dk>
Message-ID: <20141020103131.438fb440@e6520eb.localdomain>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hi Peter,

Le Mon, 20 Oct 2014 10:03:00 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :

> 
> >>>>> "Eric" == Eric B?nard <eric@eukrea.com> writes:
> 
>  > - update bootloader to 2014.07 with fslc patches
> 
> fslc? Do you mean Freescale?
> 
fscl means "Freescale Community" : 
http://freescale.github.io/
https://community.freescale.com/welcome
so the suffix -fslc is added to u-boot & linux git trees :
https://github.com/Freescale/u-boot-fslc
https://github.com/Freescale/linux-fslc

>  > - update kernel to 2.6.35_maintain branch which contains latest
>  > fixes
>  > - defconfig was then generated by savedefconfig which suppressed
>  > and reordered some items which explains the number of lines
>  > changed.
> 
>  > Tested on an i.MX53 QSB and an i.MX53 QSB-R
> 
>  > Signed-off-by: Eric B?nard <eric@eukrea.com>
>  > ---
>  >  configs/mx53loco_defconfig | 24 +++++++++---------------
>  >  1 file changed, 9 insertions(+), 15 deletions(-)
> 
>  > diff --git a/configs/mx53loco_defconfig
>  > b/configs/mx53loco_defconfig index 8b12238..6e59e5b 100644
>  > --- a/configs/mx53loco_defconfig
>  > +++ b/configs/mx53loco_defconfig
>  > @@ -1,22 +1,16 @@
>  > -# Architecture
>  >  BR2_arm=y
>  >  BR2_cortex_a8=y
>  > -BR2_ARM_FPU_VFPV3D16=y
>  > -
>  > -# System
>  >  BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
>  > -BR2_TARGET_UBOOT=y
>  > -BR2_TARGET_UBOOT_BOARDNAME="mx53_loco"
>  > -BR2_TARGET_UBOOT_CUSTOM_GIT=y
>  > -BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://git.freescale.com/imx/uboot-imx.git"
>  > -BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
>  > -
>  > -# filesystem
>  > -BR2_TARGET_ROOTFS_EXT2=y
>  > -
>  > -# Kernel
> 
> I prefer to keep the section comments, but OK.
> 
make savedefconfig automagically removed the comments.
I you prefer I can manually reintroduce them.

>  >  BR2_LINUX_KERNEL=y
>  >  BR2_LINUX_KERNEL_CUSTOM_GIT=y
>  >  BR2_LINUX_KERNEL_CUSTOM_REPO_URL="git://git.freescale.com/imx/linux-2.6-imx.git"
>  > -BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="rel_imx_2.6.35_11.09.01"
>  > +BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="imx_2.6.35_maintain"
> 
> _VERSION has to uniquely specify a revision, so it must be a tag or a
> sha1 - And not a branch.
> 
then the help is misleading as it says (for
BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION and for
BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION) :
"Revision to use in the typical format used by Git/Mercurial
E.G. a sha id, a tag, _branch_ , .. "

> So use b3912bb8a4caf3ec50909135e88af959982c43ca instead.
> 
OK will do in v2.

>  >  BR2_LINUX_KERNEL_DEFCONFIG="imx5"
>  > +BR2_LINUX_KERNEL_ZIMAGE=y
>  > +BR2_TARGET_ROOTFS_EXT2=y
>  > +BR2_TARGET_UBOOT=y
>  > +BR2_TARGET_UBOOT_BOARDNAME="mx53loco"
>  > +BR2_TARGET_UBOOT_CUSTOM_GIT=y
>  > +BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://github.com/Freescale/u-boot-imx.git"
> 
> The github page seems to redirect this to u-boot-fslc - So perhaps use
> that instead?
> 
OK

>  > +BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="patches-2014.07"
> 
> Same comment as for the kernel.
> 
OK

Thanks,
Eric