From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Complain loudly if BR2_GLOBAL_PATCH_DIR does not exit
Date: Tue, 21 Oct 2014 18:58:17 +0200 [thread overview]
Message-ID: <20141021165817.GI3912@free.fr> (raw)
In-Reply-To: <1413880974-30138-1-git-send-email-sojka@merica.cz>
Michal, All,
On 2014-10-21 10:42 +0200, Michal Sojka spake thusly:
> If the BR2_GLOBAL_PATCH_DIR is misspelled in the .config or if somebody
> renamed the existing directory with patches, buildroot happily builds
> everything but without the patches. As this can lead to surprising
> results,
Indeed... :-/
> it is better to fail and give a user a message that
> BR2_GLOBAL_PATCH_DIR is wrongly configured.
>
> Signed-off-by: Michal Sojka <sojka@merica.cz>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/pkg-generic.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 259ee02..46d92aa 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -162,6 +162,11 @@ $(BUILD_DIR)/%/.stamp_patched:
> $(Q)touch $@
> @$(call step_end,patch)
>
> +# Check that all directories specified in BR2_GLOBAL_PATCH_DIR exist.
> +$(foreach dir,$(call qstrip,$(BR2_GLOBAL_PATCH_DIR)),\
> + $(if $(wildcard $(dir)),,\
> + $(error BR2_GLOBAL_PATCH_DIR contains nonexistent directory $(dir))))
> +
> # Configure
> $(BUILD_DIR)/%/.stamp_configured:
> @$(call step_start,configure)
> --
> 2.1.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-21 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 8:42 [Buildroot] [PATCH] Complain loudly if BR2_GLOBAL_PATCH_DIR does not exit Michal Sojka
2014-10-21 16:58 ` Yann E. MORIN [this message]
2014-10-22 11:26 ` Maxime Hadjinlian
2014-10-22 11:43 ` Michal Sojka
2014-10-22 11:54 ` Maxime Hadjinlian
2014-10-22 14:01 ` Michal Sojka
2014-10-22 14:26 ` Maxime Hadjinlian
2014-10-22 16:35 ` Arnout Vandecappelle
2014-10-23 17:41 ` Maxime Hadjinlian
2014-10-24 23:58 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021165817.GI3912@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox