From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] iptables: disable static for dynamic builds
Date: Tue, 21 Oct 2014 19:04:14 +0200 [thread overview]
Message-ID: <20141021170414.GJ3912@free.fr> (raw)
In-Reply-To: <1413910694-21496-1-git-send-email-gustavo@zacarias.com.ar>
Gustavo, All,
On 2014-10-21 13:58 -0300, Gustavo Zacarias spake thusly:
> It leads to ugly runtime warnings, see:
> http://patchwork.ozlabs.org/patch/386215/
> It's also required for xtables-addons.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Seems sensible to me:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/iptables/iptables.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/iptables/iptables.mk b/package/iptables/iptables.mk
> index f059807..2ef879d 100644
> --- a/package/iptables/iptables.mk
> +++ b/package/iptables/iptables.mk
> @@ -12,7 +12,9 @@ IPTABLES_DEPENDENCIES = host-pkgconf \
> $(if $(BR2_PACKAGE_LIBNETFILTER_CONNTRACK),libnetfilter_conntrack)
> IPTABLES_LICENSE = GPLv2
> IPTABLES_LICENSE_FILES = COPYING
> -IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr
> +# Building static causes ugly warnings on some plugins
> +IPTABLES_CONF_OPTS = --libexecdir=/usr/lib --with-kernel=$(STAGING_DIR)/usr \
> + $(if $(BR2_PREFER_STATIC_LIB),,--disable-static)
> # Because of iptables-01-fix-static-link.patch
> IPTABLES_AUTORECONF = YES
>
> --
> 2.0.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-10-21 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 16:58 [Buildroot] [PATCH] iptables: disable static for dynamic builds Gustavo Zacarias
2014-10-21 17:02 ` Thomas Petazzoni
2014-10-21 17:06 ` Gustavo Zacarias
2014-10-21 17:04 ` Yann E. MORIN [this message]
2014-10-22 19:38 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021170414.GJ3912@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox