From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra/pkg-kconfig: fix saving the config file
Date: Wed, 22 Oct 2014 22:51:33 +0200 [thread overview]
Message-ID: <20141022225133.59ae7d55@free-electrons.com> (raw)
In-Reply-To: <1413836616-4209-1-git-send-email-yann.morin.1998@free.fr>
Dear Yann E. MORIN,
On Mon, 20 Oct 2014 22:23:36 +0200, Yann E. MORIN wrote:
> When saving (aka updating) the configuration file of a kconfig package,
> a subsequent call to "make" would rebuild the package, even though the
> configuration did not actually change.
>
> It took quite a while to understand why. But the reason is so simple and
> obvious, when you think about it:
>
> - $(@D)/.config depends on the config file $(BUSYBOX_CONFIG_FILE)
> - busybox-update-config then copies $(@D)/.config back to the config
> file $(BUSYBOX_CONFIG_FILE)
> - so the config file is newer than $(@D)/.config
>
> So, in the next run, pkg-kconfig believes that it has to rebuild
> busybox. Bummer... :-/
>
> So, the fix is very trivial, and just requires asking "cp" to preserve
> timestamps, so the dependency does not kick in at the next run.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-10-22 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 20:23 [Buildroot] [PATCH] infra/pkg-kconfig: fix saving the config file Yann E. MORIN
2014-10-22 8:53 ` Thomas De Schampheleire
2014-10-22 20:51 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022225133.59ae7d55@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox