From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] intltool: fix build
Date: Thu, 23 Oct 2014 22:08:56 +0200 [thread overview]
Message-ID: <20141023220856.2bd3203d@free-electrons.com> (raw)
In-Reply-To: <CAB0FRsv_6MEV1WuboQcWp9YpZgz4xvCTg9fr4t2cBy4ydfR6qg@mail.gmail.com>
Dear Fran?ois Perrad,
On Wed, 22 Oct 2014 19:15:36 +0200, Fran?ois Perrad wrote:
> > Can you cook an updated version of this patch that takes into account
> > the comment you have received? It would help us fix a number of Perl
> > related autobuilder issues.
>
> When I try to do that you suggest, I only obtain no working result.
>
> I think that comments from Arnout, come from a pure review but no from
> testing or experiment.
>
> This patch doesn't try to fix the package host-intltool, it fixes the
> packages which depend on host-intltool.
> Currently, this kind of package is broken in the configure step
> because they can not find the correct perl.
> So, the variable INTLTOOL_PERL=$(PERL) in *_CONFIGURE_OPTS is mandatory.
>
> When PATH=$(BR_PATH), `which perl` find the system perl when host-perl
> is not yet installed, after it find the host-perl.
> So, it is important to save the result of `which perl` with the
> original PATH (ie. without $(HOST_DIR)/usr/bin).
>
> The current patch stay the best that I can do (the commit message can
> always be improved).
Hum, right, ok. I'm not a big fan of how we handle intltool, but I
admit that the main reason for this mess is me asking you to not make
intltool and libxml-parser-perl depend on host-perl.
I've applied your patch (after slightly rewording the commit log), it
indeed seems to fix the issue. We'll see how things go, but I'm not
very happy with our intltool handling :/
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-10-23 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-17 18:48 [Buildroot] [PATCH] intltool: fix build Francois Perrad
2014-10-19 10:40 ` Bernd Kuhls
2014-10-19 22:50 ` Arnout Vandecappelle
2014-10-22 16:03 ` Thomas Petazzoni
2014-10-22 17:15 ` François Perrad
2014-10-23 20:08 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141023220856.2bd3203d@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox