Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] snowball-hdmiservice: Use github call
Date: Fri, 24 Oct 2014 16:57:09 -0700	[thread overview]
Message-ID: <20141024235709.GF14818@free.fr> (raw)
In-Reply-To: <1413136827-31792-1-git-send-email-maxime.hadjinlian@gmail.com>

Maxime, All,

On 2014-10-12 20:00 +0200, Maxime Hadjinlian spake thusly:
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Note: this patch also removes trailing spaces+tab, which is not readily
visible in a mail, you should have stated so in the commit log, somethig
like:

    Also get rid of traling spaces+tabs.

Regards,
Yann E. MORIN.

> ---
>  package/snowball-hdmiservice/snowball-hdmiservice.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/snowball-hdmiservice/snowball-hdmiservice.mk b/package/snowball-hdmiservice/snowball-hdmiservice.mk
> index f254414..267b5ad 100644
> --- a/package/snowball-hdmiservice/snowball-hdmiservice.mk
> +++ b/package/snowball-hdmiservice/snowball-hdmiservice.mk
> @@ -5,13 +5,13 @@
>  ################################################################################
>  
>  SNOWBALL_HDMISERVICE_VERSION = f75c99d1c52707240a78b4ba78e41d20d3aa3b08
> -SNOWBALL_HDMISERVICE_SITE = https://github.com/igloocommunity/hdmiservice
> +SNOWBALL_HDMISERVICE_SITE = $(call github,igloocommunity,hdmiservice,$(SNOWBALL_HDMISERVICE_VERSION))
>  SNOWBALL_HDMISERVICE_LICENSE = MIT
>  SNOWBALL_HDMISERVICE_LICENSE_FILES = debian/copyright
>  SNOWBALL_HDMISERVICE_INSTALL_STAGING = YES
>  
>  define SNOWBALL_HDMISERVICE_BUILD_CMDS
> -	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)" 	
> +	$(MAKE) -C $(@D) CC="$(TARGET_CC) $(TARGET_CFLAGS)"
>  endef
>  
>  define SNOWBALL_HDMISERVICE_INSTALL_STAGING_CMDS
> -- 
> 2.1.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-10-24 23:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-12 18:00 [Buildroot] [PATCH] snowball-hdmiservice: Use github call Maxime Hadjinlian
2014-10-24 23:57 ` Yann E. MORIN [this message]
2014-10-25  0:04 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141024235709.GF14818@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox