Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] shairplay-sync: new package
Date: Sat, 25 Oct 2014 18:49:27 +0200	[thread overview]
Message-ID: <20141025184927.11fb4c7d@free-electrons.com> (raw)
In-Reply-To: <56aabaa3604876fb38ac9833169f1b88@posteo.de>

Dear J?rg Krause,

On Sat, 25 Oct 2014 15:41:02 +0200, J?rg Krause wrote:

> Many thanks for the thorough review! You even checked the license!
> 
> One question to the init script file: shairport-sync uses libdaemon for 
> creating the pidfile. Does this conflicts with the `-p` switch of 
> start-stop-daemon?

Well, in most cases, we use the daemonization feature of
start-stop-daemon rather than the built-in capability of the program to
daemonize itself. Which is why I've removed the -d option from
shairplay-sync.

Could you check if it continues to work properly for you? On my system,
I wasn't able to run shairplay-sync properly, because it seems to
require multicast support in the kernel, which wasn't enabled in my
case.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-10-25 16:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 22:55 [Buildroot] [PATCH v2 1/1] shairplay-sync: new package Jörg Krause
2014-10-25 10:29 ` Thomas Petazzoni
2014-10-25 13:41   ` Jörg Krause
2014-10-25 16:49     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141025184927.11fb4c7d@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox