From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] sysv init scripts: use symbolic names in trap command
Date: Sun, 26 Oct 2014 18:53:37 +0100 [thread overview]
Message-ID: <20141026185337.58c8a7d2@free-electrons.com> (raw)
In-Reply-To: <1414345306-27184-4-git-send-email-dywi@mailerd.de>
Dear Andr? Erdmann,
On Sun, 26 Oct 2014 18:41:46 +0100, Andr? Erdmann wrote:
> Not really necessary(*), but checkbashisms complains about
> "trap with signal numbers".
>
> (*) Quoting man 1p trap:
> trap [action condition...]
> [...]
> The condition can be EXIT, 0 (equivalent to EXIT),
> or a signal specified using a symbolic name, without the SIG prefix
> [...]
> XSI-conformant systems also allow numeric signal numbers[...]
>
> Only one file is affected by this commit, and it should be checked
> whether it really needs to ignore SIGTERM/SIGHUP or if the trap commands
> can simply be removed:
>
> package/proftpd/S50proftpd
>
> Signed-off-by: Andr? Erdmann <dywi@mailerd.de>
> ---
> package/proftpd/S50proftpd | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-26 17:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 17:41 [Buildroot] [PATCH 1/4] sysv init scripts: fix == bashism André Erdmann
2014-10-26 17:41 ` [Buildroot] [PATCH 2/4] sysv init scripts: remove gettext invocations André Erdmann
2014-10-26 17:53 ` Thomas Petazzoni
2014-10-26 17:41 ` [Buildroot] [PATCH 3/4] sysv init scripts: replace &>/dev/null redirection André Erdmann
2014-10-26 17:53 ` Thomas Petazzoni
2014-10-26 17:41 ` [Buildroot] [PATCH 4/4] sysv init scripts: use symbolic names in trap command André Erdmann
2014-10-26 17:53 ` Thomas Petazzoni [this message]
2014-11-11 13:12 ` [Buildroot] [PATCH 1/4] sysv init scripts: fix == bashism Gustavo Zacarias
2014-11-11 22:09 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141026185337.58c8a7d2@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox