Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libcap: Fix build error with kernel headers < 3.6
Date: Sun, 26 Oct 2014 18:54:41 +0100	[thread overview]
Message-ID: <20141026185441.7458995e@free-electrons.com> (raw)
In-Reply-To: <1414345296-19869-1-git-send-email-bernd.kuhls@t-online.de>

Dear Bernd Kuhls,

On Sun, 26 Oct 2014 18:41:36 +0100, Bernd Kuhls wrote:
> Fixes
> http://autobuild.buildroot.net/results/cce/cceb1ccacec36fb7ef41bb7cdb13b3014813b599/
> 
> XATTR_NAME_CAPS appears in kernel headers since 3.7:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/include/uapi/linux/xattr.h?id=v3.7
> 
> Before it was an internal define of the kernel:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/include/linux/xattr.h?id=607ca46e97a1b6594b29647d98a32d545c24bdff
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/libcap/Config.in |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/libcap/Config.in b/package/libcap/Config.in
> index 5b0c827..a019928 100644
> --- a/package/libcap/Config.in
> +++ b/package/libcap/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_LIBCAP
>  	bool "libcap"
> +	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
>  	help
>  	  This library implements the user-space interfaces to the
>  	  POSIX 1003.1e capabilities available in Linux kernels. These
> @@ -22,3 +23,6 @@ config BR2_PACKAGE_LIBCAP_TOOLS
>  	  CONFIG_EXT2_FS_XATTR and CONFIG_EXT2_FS_SECURITY for ext2).
>  
>  endif
> +
> +comment "libcap needs headers >= 3.7"
> +	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7

When you add a new dependency to a package, it needs to be propagated
to the reverse dependencies of that package:

package/cdrkit/Config.in:       select BR2_PACKAGE_LIBCAP
package/lxc/Config.in:  select BR2_PACKAGE_LIBCAP
package/squid/Config.in:        select BR2_PACKAGE_LIBCAP
package/systemd/Config.in:      select BR2_PACKAGE_LIBCAP

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-10-26 17:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-26 17:41 [Buildroot] [PATCH 1/1] package/libcap: Fix build error with kernel headers < 3.6 Bernd Kuhls
2014-10-26 17:54 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141026185441.7458995e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox