Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] tcpdump: use libpcap shared library
Date: Thu, 30 Oct 2014 09:20:22 +0200	[thread overview]
Message-ID: <20141030072022.GF1759@tarshish> (raw)
In-Reply-To: <67c0a327947d1f710687a04d56a3a047984f3988.1414585221.git.baruch@tkos.co.il>

Hi Buildroot list,

On Wed, Oct 29, 2014 at 02:20:21PM +0200, Baruch Siach wrote:
> Currently the tcpdump configure script finds libpcap.a in
> output/build/libpcap-[version]. This check is hard coded in aclocal.m4. Add a
> patch to optionally ignore local libpcap so that the system shared library
> version is found instead. This reduces the tcpdump binary size in a few 100KB.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  ...libpcap-when-configured-with-with-system-.patch | 78 ++++++++++++++++++++++
>  package/tcpdump/tcpdump.mk                         |  7 +-
>  2 files changed, 83 insertions(+), 2 deletions(-)
>  create mode 100644 package/tcpdump/0001-Use-system-libpcap-when-configured-with-with-system-.patch
> 
> diff --git a/package/tcpdump/0001-Use-system-libpcap-when-configured-with-with-system-.patch b/package/tcpdump/0001-Use-system-libpcap-when-configured-with-with-system-.patch
> new file mode 100644
> index 000000000000..7f8b7151c9d0
> --- /dev/null
> +++ b/package/tcpdump/0001-Use-system-libpcap-when-configured-with-with-system-.patch
> @@ -0,0 +1,78 @@
> +From 4289e62c7966e5abeb95307717cef30a51fcdccf Mon Sep 17 00:00:00 2001
> +From: Baruch Siach <baruch@tkos.co.il>
> +Date: Wed, 29 Oct 2014 13:21:05 +0200
> +Subject: [PATCH] Use system libpcap when configured with --with-system-pcap
> +
> +Don't force the local libpcap build when the system provides one. When
> +--with-system-pcap is given to configure, don't try to locate a local libpcap
> +build. This help build systems like Buildroot that store build trees in the
> +same directory, but still prefer dynamically linking against system wide
> +libpcap.so to save space.
> +
> +Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> +---
> +Status: sent upstream (https://github.com/the-tcpdump-group/tcpdump/pull/408)

The patch is now upstream: 
https://github.com/the-tcpdump-group/tcpdump/commit/4289e62c7966e5abeb95307717cef30a51fcdccf.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2014-10-30  7:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 12:20 [Buildroot] [PATCH] tcpdump: use libpcap shared library Baruch Siach
2014-10-30  7:20 ` Baruch Siach [this message]
2014-10-30 21:01 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141030072022.GF1759@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox