From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/mono: add threads dependency
Date: Sat, 1 Nov 2014 17:54:58 +0100 [thread overview]
Message-ID: <20141101165458.GC10189@free.fr> (raw)
In-Reply-To: <1414764111-21739-1-git-send-email-angelo.compagnucci@gmail.com>
Angelo, All,
On 2014-10-31 15:01 +0100, Angelo Compagnucci spake thusly:
> This patch adds a depends on BR2_TOOLCHAIN_HAS_THREADS.
Since this fixes autobuild failures, you should list at least a few of
them (the most recent ones), like:
Fixes:
http://autobuild.buildroot.net/results/ece/ece1051cb9238735130b29f76d90a4994058345a/
http://autobuild.buildroot.net/results/658/65850774d4c6b875cb6ebbf461dcc48cf8208f4f/
http://autobuild.buildroot.net/results/5d5/5d5074aa73e167099410d244a18114dbced348d1/
...
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
I've looked at uClibc, and it looks like its implementations of LT,
LT-old and NPTL do all have this, so (with the afore-mentioned autobuild
references added):
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/mono/Config.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/package/mono/Config.in b/package/mono/Config.in
> index f8f4895..cc015e6 100644
> --- a/package/mono/Config.in
> +++ b/package/mono/Config.in
> @@ -7,6 +7,7 @@ config BR2_PACKAGE_MONO
> bool "mono"
> depends on BR2_PACKAGE_MONO_ARCH_SUPPORTS
> depends on BR2_INET_IPV6
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> select BR2_PACKAGE_MONO_45 if !BR2_PACKAGE_MONO_20 && !BR2_PACKAGE_MONO_40
> help
> An open source, cross-platform, implementation of C#
> @@ -36,5 +37,5 @@ config BR2_PACKAGE_MONO_45
>
> endif
>
> -comment "mono needs a toolchain w/ IPv6"
> - depends on !BR2_INET_IPV6
> +comment "mono needs a toolchain w/ IPv6, threads"
> + depends on !BR2_INET_IPV6 || !BR2_TOOLCHAIN_HAS_THREADS
> --
> 2.1.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-11-01 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 14:01 [Buildroot] [PATCH] package/mono: add threads dependency Angelo Compagnucci
2014-11-01 16:54 ` Yann E. MORIN [this message]
2014-11-01 17:21 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141101165458.GC10189@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox