Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Fix redundant usage of -mcpu and -march/-mtune
Date: Sat, 1 Nov 2014 22:22:05 +0100	[thread overview]
Message-ID: <20141101222205.372415a3@free-electrons.com> (raw)
In-Reply-To: <1399989494-21343-2-git-send-email-kaszak@gmail.com>

Dear Karoly Kasza,

On Tue, 13 May 2014 15:58:14 +0200, Karoly Kasza wrote:
> Disable adding -mtune or -march to the external toolchain parameters
> if -mcpu is present.
> 
> Signed-off-by: Karoly Kasza <kaszak@gmail.com>
> ---
>  toolchain/toolchain-external/toolchain-external.mk |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

We discussed this patch at the last Buildroot meeting, and our feeling
is that it's not the correct approach. I've since then sent a patch
series that fix the same problem. Our approach is:

 * On ARM, to no longer specify -march, but only -mcpu, since the
   latter is used by gcc to deduce the former.

 * In general, get rid of -mtune, since it doesn't make much sense in
   the context of Buildroot where we target one specific system, and
   therefore using -mcpu is sufficient.

So, we've marked your patch as Rejected in our patch tracking system.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-11-01 21:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-13 13:58 [Buildroot] [PATCH 0/1] Fix redundant usage of -mcpu and -march/-mtune Karoly Kasza
2014-05-13 13:58 ` [Buildroot] [PATCH 1/1] " Karoly Kasza
2014-11-01 21:22   ` Thomas Petazzoni [this message]
2014-11-01 21:24     ` Károly Kasza
2014-05-13 14:04 ` [Buildroot] [PATCH 0/1] " Thomas Petazzoni
2014-05-13 14:33   ` Károly Kasza
2014-05-13 20:22     ` Thomas Petazzoni
2014-05-14  7:55       ` Károly Kasza
2014-05-14  7:59         ` Thomas Petazzoni
2014-05-14 12:33           ` Károly Kasza
2014-05-27 15:40           ` Károly Kasza

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141101222205.372415a3@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox