Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] infra: Add a way to apply patches using git
Date: Sat, 1 Nov 2014 22:47:21 +0100	[thread overview]
Message-ID: <20141101224721.29b22269@free-electrons.com> (raw)
In-Reply-To: <1404321605-20073-1-git-send-email-jezz@sysmic.org>

Dear J?r?me Pouiller,

On Wed,  2 Jul 2014 19:20:05 +0200, J?r?me Pouiller wrote:
> This option is mainly used for package developpers. When activated,
> Buildroot will automaticaly create a git repository for each package
> it extract. Initial version is tagged as `upstream'. Next, during
> patch step, git is used instead of patch. BTW, patches are easier
> to modify/fix/rebase/cherry-pick/upstream. Once satisfied with
> changes, developper may use
>     git format-patch -o $TOPDIR/package/$PKG upstream
> to save its patches to Buildroot.
> 
> Notice this option should be compatible with `guilt' (a clone of
> `quilt')
> 
> Notice you can also use this feature for a specific package using
>     make BR2_USE_GIT_TO_PATCH=y $PKG-dirclean $PKG-patch
> 
> Current known limitations:
>   - If a patch cannot be handled by `git am', we use `git apply`. In
>     this case, patch description is not reported in commit message.
>   - When patch is handled with `git apply`, subject used may not be
>     perfect (it is extracted from patch filename)
>   - `git format-patch' does not prefix patch files with name of package.
>   - If upstream was downloaded with git, we may also run
>     `git remote add $($(PKG)_SITE)' during git repository creation
> 
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>

We discussed this proposal at the last Buildroot Developers meeting.
Even though we understand the idea and some of us found it potentially
interesting, we didn't really like the implementation, but nobody
really found a way of implementing something like this in a nice way.

One of the problem is that not all our patches are Git patches, which
you had to work-around in your patch in a way that isn't really nice.

Maybe Arnout and Yann (in Cc) remember more of the issues that we
discussed at the meeting regarding this proposal.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-11-01 21:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-02 17:20 [Buildroot] [PATCH] infra: Add a way to apply patches using git Jérôme Pouiller
2014-11-01 21:47 ` Thomas Petazzoni [this message]
2014-11-01 22:06   ` Arnout Vandecappelle
2014-11-01 22:11     ` Thomas Petazzoni
2014-11-03 15:01       ` Jérôme Pouiller
2014-11-03 20:21         ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141101224721.29b22269@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox