From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sat, 1 Nov 2014 23:11:25 +0100 Subject: [Buildroot] [PATCH] infra: Add a way to apply patches using git In-Reply-To: <5455595F.6090205@mind.be> References: <1404321605-20073-1-git-send-email-jezz@sysmic.org> <20141101224721.29b22269@free-electrons.com> <5455595F.6090205@mind.be> Message-ID: <20141101231125.2ca351ca@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Arnout Vandecappelle, On Sat, 01 Nov 2014 23:06:23 +0100, Arnout Vandecappelle wrote: > > We discussed this proposal at the last Buildroot Developers meeting. > > Even though we understand the idea and some of us found it potentially > > interesting, we didn't really like the implementation, but nobody > > really found a way of implementing something like this in a nice way. > > > > One of the problem is that not all our patches are Git patches, which > > you had to work-around in your patch in a way that isn't really nice. > > > > Maybe Arnout and Yann (in Cc) remember more of the issues that we > > discussed at the meeting regarding this proposal. > > For simple patches, a simple diff is normally sufficient. For more complicated > stuff, it is really worthwhile to clone the upstream repository and work from > there - you'll anyway need to do that to upstream the patches. > > So we felt that the need for this feature did not outweigh the complexity of > its implementation. Ah yes, right: we thought that having a Git repository that isn't the one from upstream made it unpractical to submit patches back to upstream, and was making the entire feature a bit useless. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com