Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] wireshark: remove RPATH tag
Date: Wed, 5 Nov 2014 08:15:55 +0100	[thread overview]
Message-ID: <20141105081555.5aca83e2@free-electrons.com> (raw)
In-Reply-To: <0dae86e37516236d337e8433c63047504f1576f9.1415126141.git.baruch@tkos.co.il>

Dear Baruch Siach,

On Tue,  4 Nov 2014 20:35:41 +0200, Baruch Siach wrote:
> Edit libtool to remove RPATH from generated binaries. This is similar to
> upstream commit making the same change when buiding RPMs.
> https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commitdiff;h=a4a624e4c5
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/wireshark/wireshark.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/package/wireshark/wireshark.mk b/package/wireshark/wireshark.mk
> index ccf5a56f1f23..6c7c3920e7af 100644
> --- a/package/wireshark/wireshark.mk
> +++ b/package/wireshark/wireshark.mk
> @@ -15,6 +15,12 @@ WIRESHARK_AUTORECONF = YES
>  WIRESHARK_CONF_ENV = LIBGCRYPT_CONFIG=$(STAGING_DIR)/usr/bin/libgcrypt-config \
>  			ac_cv_path_PCAP_CONFIG=$(STAGING_DIR)/usr/bin/pcap-config
>  
> +define WIRESHARK_REMOVE_RPATH
> +	$(SED) 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' $(@D)/libtool
> +	$(SED) 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' $(@D)/libtool
> +endef
> +WIRESHARK_POST_CONFIGURE_HOOKS += WIRESHARK_REMOVE_RPATH

Isn't this problem potentially identical in many packages that use
libtool? What leads the wireshark libtool to have this specifically?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-11-05  7:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 18:35 [Buildroot] [PATCH] wireshark: remove RPATH tag Baruch Siach
2014-11-05  7:15 ` Thomas Petazzoni [this message]
2014-11-05  7:22   ` Baruch Siach
2014-11-05  7:31     ` Thomas Petazzoni
2014-11-17 12:33       ` Baruch Siach
2014-11-17 12:45         ` Gustavo Zacarias
2014-11-17 13:32           ` Samuel Martin
2014-11-17 13:38           ` Baruch Siach
2015-04-04 17:59 ` Thomas Petazzoni
2015-04-05  9:05   ` Yann E. MORIN
2015-04-05  9:29     ` Thomas Petazzoni
2015-04-05 10:06       ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105081555.5aca83e2@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox