From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] webkit: Add --enable-dependency-tracking to the configure options
Date: Thu, 6 Nov 2014 19:09:59 +0100 [thread overview]
Message-ID: <20141106190959.325d134f@free-electrons.com> (raw)
In-Reply-To: <1415297036-21850-1-git-send-email-Vincent.Riera@imgtec.com>
Dear Vicente Olivert Riera,
On Thu, 6 Nov 2014 18:03:56 +0000, Vicente Olivert Riera wrote:
> --disable-dependency-tracking was added globally to
> package/pkg-autotools.mk by this commit:
>
> http://git.buildroot.net/buildroot/commit/?id=3e37b0fc6cbbe2245e39fedb247a381fb4e0d992
>
> This causes a failure in webkit because some source files are generated
> after the Makefile is created. To fix this, we add
> --enable-dependency-tracking to the configure options.
>
> Fixes:
> http://autobuild.buildroot.net/results/5beea967b02df202bca1d42afd6fa8c2c13383d5/
Aaah, that's what causing the build failure of webkit. I believe it's
wrong for webkit to do that, because dependency tracking should only be
needed for the developers of the package, and not needed for a normal
build. But since we're anyway going to bump webkit at some point thanks
to the work of Eric Le Bihan, I don't think we want to debug this
webkit version.
Therefore:
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
And thanks a lot for the investigation!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-11-06 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 18:03 [Buildroot] [PATCH] webkit: Add --enable-dependency-tracking to the configure options Vicente Olivert Riera
2014-11-06 18:09 ` Thomas Petazzoni [this message]
2014-11-06 22:04 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141106190959.325d134f@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox