From: "Guido Martínez" <guido@vanguardiasur.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 5/5] package: linux-fusion: use install instead of cp
Date: Fri, 7 Nov 2014 10:16:29 -0300 [thread overview]
Message-ID: <20141107131629.GA2620@fox> (raw)
In-Reply-To: <CANxTyt6nKbvrcRFtds8CxBBuEk-Su-LL5hzqOY=-m1BT2a_v+A@mail.gmail.com>
Hi Danomi
On Fri, Nov 07, 2014 at 07:44:50AM -0500, Danomi Manchego wrote:
> Guido
>
> On Thu, Nov 6, 2014 at 10:50 PM, Guido Mart?nez
> <guido@vanguardiasur.com.ar> wrote:
> > in order to not depend on the previous permissions of the file
> >
> > Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> > ---
> > package/linux-fusion/linux-fusion.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/linux-fusion/linux-fusion.mk b/package/linux-fusion/linux-fusion.mk
> > index c5e7976..81ecd8a 100644
> > --- a/package/linux-fusion/linux-fusion.mk
> > +++ b/package/linux-fusion/linux-fusion.mk
> > @@ -37,7 +37,7 @@ define LINUX_FUSION_INSTALL_TARGET_CMDS
> > INSTALL_MOD_PATH=$(TARGET_DIR) \
> > -C $(@D) install
> > mkdir -p $(LINUX_FUSION_ETC_DIR)
> > - cp -dpf package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
> > + install -m 644 package/linux-fusion/40-fusion.rules $(LINUX_FUSION_ETC_DIR)
>
>
> How about also dropping the mkdir and doing:
>
> install -D -m 644 package/linux-fusion/40-fusion.rules
> $(LINUX_FUSION_ETC_DIR)/40-fusion.rules
Ah yes, that's better. Will do for v3.
Thanks!
>
> Danomi -
>
>
> > endef
> >
> > $(eval $(generic-package))
> > --
> > 2.1.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
--
Guido Mart?nez, VanguardiaSur
www.vanguardiasur.com.ar
prev parent reply other threads:[~2014-11-07 13:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 12:42 [Buildroot] [RFC/PATCH] target permissions Guido Martínez
2014-11-03 12:42 ` [Buildroot] [RFC/PATCH] Makefile: guarantee reproducible permissions Guido Martínez
2014-11-03 22:23 ` Arnout Vandecappelle
2014-11-03 22:31 ` Ezequiel Garcia
2014-11-05 14:46 ` Guido Martínez
2014-11-05 15:51 ` Angelo Compagnucci
2014-11-07 13:57 ` Guido Martínez
2014-11-07 3:50 ` [Buildroot] [PATCH v2 0/5] target permissions Guido Martínez
2014-11-07 3:50 ` [Buildroot] [PATCH v2 1/5] Makefile: don't depend on the umask Guido Martínez
2014-11-07 3:50 ` [Buildroot] [PATCH v2 2/5] Makefile: don't depend on current skeleton/overlay permissions Guido Martínez
2014-11-07 3:50 ` [Buildroot] [PATCH v2 3/5] pkg-generic.mk: don't depend on external package permissions Guido Martínez
2014-11-07 3:50 ` [Buildroot] [PATCH v2 4/5] package: matchbox-keyboard: use install instead of cp Guido Martínez
2014-11-07 3:50 ` [Buildroot] [PATCH v2 5/5] package: linux-fusion: " Guido Martínez
2014-11-07 12:44 ` Danomi Manchego
2014-11-07 13:16 ` Guido Martínez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107131629.GA2620@fox \
--to=guido@vanguardiasur.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox