Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] arch/Config.in.x86: drop BR2_x86_generic
Date: Sat, 8 Nov 2014 18:35:14 +0100	[thread overview]
Message-ID: <20141108183514.7d42611c@free-electrons.com> (raw)
In-Reply-To: <87fvduue57.fsf@dell.be.48ers.dk>

Dear Peter Korsgaard,

On Sat, 08 Nov 2014 12:26:28 +0100, Peter Korsgaard wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> 
>  > Dear Peter Korsgaard,
>  > On Fri, 7 Nov 2014 19:51:06 +0100, Peter Korsgaard wrote:
>  >> commit: http://git.buildroot.net/buildroot/commit/?id=80e406090893ab5a7b5d78e4d243d12fca2b22fb
>  >> branch: http://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>  >> 
>  >> The fuzzy generic x86 variant doesn't make much sense in the context of
>  >> Buildroot, and the recent change to use -march instead of -mtune broke it.
> 
>  > No Config.in.legacy handling?
> 
> It is only used in the variant choice, so kconfig will automatically
> change to the default value (586 for i386, nocona for x86-64) and as
> "generic" is not really well defined (see the description in the GCC
> manual) I think that is good enough - But yeah, we should inform the
> user about it using the legacy support.

I agree that the default behavior after the removal of BR2_x86_generic
is sane, but I believe it still makes sense to have Config.in.legacy
handling to warn users about this.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-11-08 17:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 18:51 [Buildroot] [git commit] arch/Config.in.x86: drop BR2_x86_generic Peter Korsgaard
2014-11-08 10:01 ` Thomas Petazzoni
2014-11-08 11:26   ` Peter Korsgaard
2014-11-08 17:35     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141108183514.7d42611c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox