From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] elfutils: bump version to 0.160
Date: Mon, 10 Nov 2014 16:29:33 +0100 [thread overview]
Message-ID: <20141110152933.GC2466@free.fr> (raw)
In-Reply-To: <20141110151938.GB2466@free.fr>
Vicente, All,
On 2014-11-10 16:19 +0100, Yann E. MORIN spake thusly:
> Vicente, Samuel, All,
>
> On 2014-11-10 13:17 +0000, Vicente Olivert Riera spake thusly:
> > On 11/10/2014 12:31 PM, Samuel Martin wrote:
> > > On Mon, Nov 10, 2014 at 11:45 AM, Vicente Olivert Riera
> > > <Vincent.Riera@imgtec.com> wrote:
> > >> - Bump version to 0.160
> > >> - Add a hash file
> > >> - Add a hook to remove some -Werror options
> > >>
> > >> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> [--SNIP--]
> > >> +# The --disable-werror configure option does not seem to be enough. We
> > >> +# need to remove the -Werror options from these Makefiles in order to
> > >> +# avoid compilation failures.
> > >> +define ELFUTILS_DISABLE_WERROR
> > >> + $(SED) 's/-Werror//g' $(@D)/lib/Makefile
> > >> + $(SED) 's/-Werror//g' $(@D)/libelf/Makefile
> > >> + $(SED) 's/-Werror//g' $(@D)/libdwfl/Makefile
> > >> +endef
> > >> +ELFUTILS_POST_CONFIGURE_HOOKS += ELFUTILS_DISABLE_WERROR
> > >
> > > Since we are already reconfiguring elfutils, is it possible to patch
> > > the Makefile.am or Makefile.in instead?
> >
> > I tried it but I couldn't get rid of that by just modifying the
> > Makefile.{am,in}, that's why I ended with that solution. If you can try
> > it I would be very appreciated.
>
> I managed to get it build without the hook, using that patch:
>
> infra: really make -Werror condiftional to BUILD_WERROR
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> diff -durN elfutils-0.160.orig/config/eu.am elfutils-0.160/config/eu.am
> --- elfutils-0.160.orig/config/eu.am2014-11-10 16:15:26.644739769 +0100
> ++ + elfutils-0.160/config/eu.am2014-11-10 16:15:52.745052929 +0100
> @@ -3 5,7 +35,6 @@
> DEFS = -D_GNU_SOURCE -DHAVE_CONFIG_H -DLOCALEDIR='"${localedir}"'
> AM_CPPFLAGS = -I. -I$(srcdir) -I$(top_srcdir)/lib -I..
> AM_CFLAGS = -std=gnu99 -Wall -Wshadow \
> - $(if $($(*F)_no_Werror),,-We rror) \
> $(if $($(*F)_no_Wunused),,-Wunused $(WEXTRA)) \
> $(if $($(*F)_no_Wformat),-Wno-format,-Wformat=2) \
> $($(*F)_CFLAGS)
Dang.. The patch was mangled somehow...
To make it clear what I did: I removed line 38 from config/eu.am
You can re-use my patch description and sob when you submit your v2.
Feel free to update as you see fit. ;-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2014-11-10 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-10 10:45 [Buildroot] [PATCH 1/2] elfutils: bump version to 0.160 Vicente Olivert Riera
2014-11-10 10:45 ` [Buildroot] [PATCH 2/2] elfutils: Adapt patches to the new version Vicente Olivert Riera
2014-11-10 14:17 ` Yann E. MORIN
2014-11-10 12:31 ` [Buildroot] [PATCH 1/2] elfutils: bump version to 0.160 Samuel Martin
2014-11-10 13:17 ` Vicente Olivert Riera
2014-11-10 15:19 ` Yann E. MORIN
2014-11-10 15:26 ` Vicente Olivert Riera
2014-11-10 15:29 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141110152933.GC2466@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox