From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 10 Nov 2014 19:44:04 +0100 Subject: [Buildroot] [PATCH] inetutils: new package In-Reply-To: References: <1414624048-37143-1-git-send-email-kaszak@gmail.com> <852735167.27218624.1414655605361.JavaMail.root@openwide.fr> <20141030094018.GH1759@tarshish> <20141030125801.GO1759@tarshish> <20141101200125.509c0b89@free-electrons.com> <20141101213117.6673aa69@free-electrons.com> Message-ID: <20141110194404.15efb715@free-electrons.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear K?roly Kasza, On Sun, 2 Nov 2014 13:45:19 +0100, K?roly Kasza wrote: > I wrote a small script to analyse which files are redundant, and if they > will be overwritten or not. > I ran it against busybox, net-tools, iputils, rsh-redone, sysklogd and > whois because I found that these > packages may overlap with inetutils' tools. > > The same filename lines mean that an other file with the same name, but > with a different path exists > (the compared package's path is in the brackets). > The same path lines mean that it would be overwritten at install. > > busybox: > Found same filename /usr/bin/dnsdomainname (/bin/dnsdomainname) > Found same filename /usr/bin/ping (/bin/ping) > Found same filename /usr/bin/hostname (/bin/hostname) > Found same filename /usr/bin/ifconfig (/sbin/ifconfig) > Found same filename /usr/libexec/syslogd (/sbin/syslogd) > Found same path /usr/bin/traceroute > Found same path /usr/bin/tftp > Found same path /usr/bin/logger > Found same path /usr/bin/telnet > Found same filename /usr/libexec/inetd (/usr/sbin/inetd) > > net-tools: > Found same filename /usr/bin/dnsdomainname (/bin/dnsdomainname) > Found same filename /usr/bin/hostname (/bin/hostname) > Found same filename /usr/bin/ifconfig (/sbin/ifconfig) > Found same path /usr/share/man/man1/dnsdomainname.1 > Found same path /usr/share/man/man1/hostname.1 > > iputils: > Found same filename /usr/bin/ping6 (/bin/ping6) > Found same filename /usr/bin/ping (/bin/ping) > > rsh-redone: > Found same path /usr/bin/rlogin > Found same path /usr/bin/rsh > > sysklogd: > Found same filename /usr/libexec/syslogd (/sbin/syslogd) > > whois: > Found same path /usr/share/man/man1/whois.1 > Found same path /usr/bin/whois > > I think a solution would be to disable inetutils' redundant tools: > whois, sysklogd, rlogin(d), rsh(d), ping, ping6, hostname, dnsdomainname, > ifconfig, hostname. > > After that, the only utility, that's not overwritten would be inetd from > busybox, where a post-install hook > could simply alter the busybox symlink to point to inetutils' version > instead. > > I'm waiting for your opinions! Personally, I think we should keep all of those tools enabled, and simply fix the installation path, especially since inetutils is often the only one doing "weird" things, and all of the other packages agree on the location for all tools First, for the "Found same path" cases above, I believe the solution is fairly easy: just make sure inetutils depends on the relevant packages so that they get overriden. For busybox it's easy, we always want the inetutils tools to override the busybox one. For the other packages, it might need a little bit more discussion as it's not immediately clear which package has the "best" implementation for each of the tools. Now, for the "Found same filename" cases, the situation is quite clear: * dnsdomainname: both busybox and net-tools install it to /bin, inetutils is the only one to choose /usr/bin. So the solution is to move it to /bin in inetutils. * ping: both busybox and iputils install it to /bin, so same solution as above. * hostname: both busybox and net-tools install it to /bin, so same solution. * ifconfig: both busybox, and net-tools install it to /sbin, so same solution. * syslogd: both busybox and sysklogd install it to /sbin, so same solution. You can also try to pass --exec-prefix=/ in INETUTILS_CONF_OPTS and see if it improves the situation. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com