Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/4] rt-tests: patches rename & versoin bump & support of non-NPTL tools
Date: Tue, 11 Nov 2014 15:43:40 +0100	[thread overview]
Message-ID: <20141111154340.258edd64@free-electrons.com> (raw)
In-Reply-To: <1415613549-2886-1-git-send-email-abrodkin@synopsys.com>

Dear Alexey Brodkin,

On Mon, 10 Nov 2014 12:59:05 +0300, Alexey Brodkin wrote:

> Alexey Brodkin (4):
>   rt-tests: rename patch to the new convention
>   rt-tests: switch site from Debian snapshot to Linux's git
>   rt-tests: bump version to 0.89
>   rt-tests: allow building subset of tests with non-NPTL toolchains

Applied patches 1 to 3. Patch 4 not applied as a new version was sent.
However, I wanted to mention two things:

 * You should never resend a new version of just one patch. Always send
   the complete series again, even if only one patch has changed. I was
   mistaken when looking at patchwork, and originally only applied the
   patch removing the NPTL dependency, because it was available
   standalone, outside of any series.

 * You should use 'git format-patch -M' to enable rename detection. It
   would have made patch 1 a lot smaller, and easier to review.

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-11-11 14:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-10  9:59 [Buildroot] [PATCH 0/4] rt-tests: patches rename & versoin bump & support of non-NPTL tools Alexey Brodkin
2014-11-10  9:59 ` [Buildroot] [PATCH 1/4] rt-tests: rename patch to the new convention Alexey Brodkin
2014-11-10  9:59 ` [Buildroot] [PATCH 2/4] rt-tests: switch site from Debian snapshot to Linux's git Alexey Brodkin
2014-11-10  9:59 ` [Buildroot] [PATCH 3/4] rt-tests: bump version to 0.89 Alexey Brodkin
2014-11-10  9:59 ` [Buildroot] [PATCH 4/4] rt-tests: allow building subset of tests with non-NPTL toolchains Alexey Brodkin
2014-11-10 10:06   ` Thomas Petazzoni
2014-11-10 10:24     ` Alexey Brodkin
2014-11-11 14:43 ` Thomas Petazzoni [this message]
2014-11-11 15:01   ` [Buildroot] [PATCH 0/4] rt-tests: patches rename & versoin bump & support of non-NPTL tools Alexey Brodkin
2014-11-11 15:10     ` Thomas Petazzoni
2014-11-11 20:59       ` Peter Korsgaard
2014-11-11 22:15         ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141111154340.258edd64@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox