Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/nodejs: fix build error without OpenSSL support
Date: Sun, 16 Nov 2014 12:55:13 +0100	[thread overview]
Message-ID: <20141116125513.1fac7eae@free-electrons.com> (raw)
In-Reply-To: <1416087173-21595-1-git-send-email-jkrause@posteo.de>

Dear J?rg Krause,

On Sat, 15 Nov 2014 22:32:53 +0100, J?rg Krause wrote:
> Version 0.10.33 of nodejs introduced a bug which prevents us from building
> nodejs without OpenSSL support. The bug is reported upstream:
> https://github.com/joyent/node/issues/8676
> 
> This bug caused some build errors:
>   * http://autobuild.buildroot.net/results/0bf/0bf17bf710db051d491123482c90f2f72810804b/
>   * http://autobuild.buildroot.net/results/e1f/e1fb34818ff1167aa008b4011befb9fd14c81293/
> 
> and more...
> 
> nodejs can be build with shared linking to an external OpenSSL library (by
> setting `--shared-openssl`) or with static linking to the bundled OpenSSL
> library.
> 
> With this patch nodejs is build with static linking to the bundled OpenSSL
> library in case no OpenSSL package is selected.

I don't think this is the right fix. We don't want to use the bundled
OpenSSL library, that's contrary to what we do in the rest of Buildroot.
The proper fixes are either fixing the bug that prevents nodejs from
building without OpenSSL, or make nodejs select unconditionally OpenSSL.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-11-16 11:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 21:32 [Buildroot] [PATCH 1/1] package/nodejs: fix build error without OpenSSL support Jörg Krause
2014-11-16 11:55 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141116125513.1fac7eae@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox