[Buildroot] [PATCH V2 3/4] c-icap: new package

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Dear Guillaume GARDET,

On Wed, 12 Nov 2014 17:16:32 +0100, Guillaume GARDET wrote:
> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> 
> ---
>  package/Config.in        |  1 +
>  package/c-icap/Config.in | 10 ++++++++++
>  package/c-icap/c-icap.mk | 27 +++++++++++++++++++++++++++
>  3 files changed, 38 insertions(+)
>  create mode 100644 package/c-icap/Config.in
>  create mode 100644 package/c-icap/c-icap.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 28cf703..fe0af07 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -983,6 +983,7 @@ menu "Networking applications"
>  	source "package/boa/Config.in"
>  	source "package/bridge-utils/Config.in"
>  	source "package/bwm-ng/Config.in"
> +	source "package/c-icap/Config.in"
>  	source "package/can-utils/Config.in"
>  	source "package/chrony/Config.in"
>  	source "package/civetweb/Config.in"
> diff --git a/package/c-icap/Config.in b/package/c-icap/Config.in
> new file mode 100644
> index 0000000..e8ac241
> --- /dev/null
> +++ b/package/c-icap/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_C_ICAP
> +	bool "c-icap"

A quick look at the source seems to indicate that this package uses
thread support, so you should depend on BR2_TOOLCHAIN_HAS_THREADS, and
add the corresponding comment (see other packages for examples).

> +	help
> +	  c-icap is an implementation of an ICAP server. It can be used with 
> +	  HTTP proxies that support the ICAP protocol to implement content 
> +	  adaptation and filtering services.
> +	  Most of the commercial HTTP proxies must support the ICAP protocol.
> +	  The open source Squid 3.x proxy server supports it.
> +
> +	  http://c-icap.sourceforge.net/
> diff --git a/package/c-icap/c-icap.mk b/package/c-icap/c-icap.mk
> new file mode 100644
> index 0000000..8f93638
> --- /dev/null
> +++ b/package/c-icap/c-icap.mk
> @@ -0,0 +1,27 @@
> +################################################################################
> +#
> +# c-icap
> +#
> +################################################################################
> +
> +C_ICAP_VERSION = 0.3.5
> +C_ICAP_SOURCE = c_icap-$(C_ICAP_VERSION).tar.gz
> +C_ICAP_SITE = http://downloads.sourceforge.net/c-icap/
> +C_ICAP_LICENSE = LGPLv2.1+
> +C_ICAP_LICENSE_FILES = COPYING
> +C_ICAP_INSTALL_STAGING = YES
> +C_ICAP_CONF_OPTS = --sysconfdir=/etc --with-process-mutexes=posix

--sysconfdir=/etc is not needed, it is already passed by the
autotools-package infrastructure to all target packages.

> +ifeq ($(BR2_LARGEFILE),y)
> +C_ICAP_CONF_OPTS += --enable-large-files
> +else
> +C_ICAP_CONF_OPTS += --disable-large-files
> +endif
> +
> +define C_ICAP_INSTALL_TARGET_CONFIGS
> +	mkdir -p $(TARGET_DIR)/var/run/c-icap/
> +	mkdir -p $(TARGET_DIR)/tmp/c-icap/
> +endef

Like your change for squid, I don't think this makes sense because /tmp
is mounted as a tmpfs, and /var/run is a symlink to /tmp.

You also probably want:

ifeq ($(BR2_INET_IPV6),y)
C_ICAP_CONF_OPTS += --enable-ipv6
else
C_ICAP_CONF_OPTS += --disable-ipv6
endif

Probably also --without-perl, unless perl is a mandatory dependency.

Also, looking at configure.in, it needs the libdl library, so you'll
need to depend on !BR2_PREFER_STATIC_LIB in Config.in.

It also has some optional dependencies on zlib, bzip2, berkeleydb and
ldap.

For the first three, you can to handle the optional dependencies, by
doing something like:

ifeq ($(BR2_PACKAGE_ZLIB),y)
C_ICAP_CONF_OPTS += --with-zlib
C_ICAP_DEPENDENCIES += zlib
else
C_ICAP_CONF_OPTS += --without-zlib
endif

For the last one, since we don't have a LDAP package in Buildroot,
simply pass --without-ldap in C_ICAP_CONF_OPTS.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com