From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/rpm: add missing dependency to openssl
Date: Mon, 17 Nov 2014 18:59:18 +0100 [thread overview]
Message-ID: <20141117175917.GA12473@free.fr> (raw)
In-Reply-To: <87h9xyd8wv.fsf@dell.be.48ers.dk>
Peter, All,
On 2014-11-17 00:26 +0100, Peter Korsgaard spake thusly:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
> > We forcibly enable use of an extrernal openssl in rpm, so we must depend
> > on it.
>
> > openssl is correctly selected from kconfig, but there is no build-time
> > dependency to it.
>
> > It was not an issue so far, because openssl always sorts before rpm, so
> > gets built before. Unless one wants to just build rpm to debug an
> > autobuilder failure, that is.
>
> > Add that build-time dependency to openssl.
>
> Committed, thanks.
>
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > ---
> > package/rpm/rpm.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> > diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
> > index af1642f..50e6d75 100644
> > --- a/package/rpm/rpm.mk
> > +++ b/package/rpm/rpm.mk
> > @@ -7,7 +7,7 @@
> > RPM_VERSION_MAJOR = 5.2
> > RPM_VERSION = $(RPM_VERSION_MAJOR).0
> > RPM_SITE = http://rpm5.org/files/rpm/rpm-$(RPM_VERSION_MAJOR)
> > -RPM_DEPENDENCIES = zlib beecrypt neon popt
> > +RPM_DEPENDENCIES = zlib beecrypt neon popt openssl
>
> A quick check seems to show that zlib isn't selected from Config.in. Is
> it needed (besides indirectly from openssl)?
Yes, rpm needs it, too. I'll cook a patch. Thanks for noticing.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2014-11-17 17:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-16 22:56 [Buildroot] [PATCH] package/rpm: add missing dependency to openssl Yann E. MORIN
2014-11-16 23:26 ` Peter Korsgaard
2014-11-17 17:59 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117175917.GA12473@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox