From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] package/sdl_sound: fix constness in debug mode
Date: Mon, 17 Nov 2014 20:09:19 +0100 [thread overview]
Message-ID: <20141117190919.GC12473@free.fr> (raw)
In-Reply-To: <1416250380-24029-1-git-send-email-yann.morin.1998@free.fr>
All,
On 2014-11-17 19:53 +0100, Yann E. MORIN spake thusly:
> When in debug mode, ./configure forces -Werror, which uncovers a
> constness issue in the speex decoder.
>
> Add a patch to fix this.
Patch was submitted upstream, but is help in moderation because I am not
subscribed to their mailing list. As soon as I have an answer, I'll post
it here (at least a pointer to the thread).
Regards,
Yann E. MORIN.
> Fixes:
> http://autobuild.buildroot.net/results/6f5/6f5e1b782923d6e69e929466f0ddd3eeba28c6f1/
> http://autobuild.buildroot.net/results/c1b/c1b31dc37fe62cb6901edad02bf50d73072b7cf0/
> http://autobuild.buildroot.net/results/162/162e6d77e5812060001ea22faff99055aae3122a/
> ...
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/sdl_sound/0001-fix-constness.patch | 16 ++++++++++++++++
> package/sdl_sound/sdl_sound.mk | 3 +++
> 2 files changed, 19 insertions(+)
> create mode 100644 package/sdl_sound/0001-fix-constness.patch
>
> diff --git a/package/sdl_sound/0001-fix-constness.patch b/package/sdl_sound/0001-fix-constness.patch
> new file mode 100644
> index 0000000..1f27a07
> --- /dev/null
> +++ b/package/sdl_sound/0001-fix-constness.patch
> @@ -0,0 +1,16 @@
> +decoders/speex: fix constness of speex mode
> +
> +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> +
> +diff -durN sdl_sound-1.0.3.orig/decoders/speex.c sdl_sound-1.0.3/decoders/speex.c
> +--- sdl_sound-1.0.3.orig/decoders/speex.c 2014-11-17 19:40:09.543553556 +0100
> ++++ sdl_sound-1.0.3/decoders/speex.c 2014-11-17 19:40:37.119864580 +0100
> +@@ -124,7 +124,7 @@
> +
> + static int process_header(speex_t *speex, Sound_Sample *sample)
> + {
> +- SpeexMode *mode;
> ++ const SpeexMode * mode;
> + SpeexHeader *hptr;
> + SpeexHeader header;
> + int enh_enabled = SPEEX_USE_PERCEPTUAL_ENHANCER;
> diff --git a/package/sdl_sound/sdl_sound.mk b/package/sdl_sound/sdl_sound.mk
> index 416f381..6180b42 100644
> --- a/package/sdl_sound/sdl_sound.mk
> +++ b/package/sdl_sound/sdl_sound.mk
> @@ -12,6 +12,9 @@ SDL_SOUND_LICENSE_FILES = COPYING
> SDL_SOUND_INSTALL_STAGING = YES
> SDL_SOUND_DEPENDENCIES = sdl
>
> +# Patch touching configure.in
> +SDL_SOUND_AUTORECONF = YES
> +
> ifneq ($(BR2_ENABLE_LOCALE),y)
> SDL_SOUND_DEPENDENCIES += libiconv
> endif
> --
> 1.9.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-11-17 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 18:53 [Buildroot] [PATCHv2] package/sdl_sound: fix constness in debug mode Yann E. MORIN
2014-11-17 19:09 ` Yann E. MORIN [this message]
2014-11-17 19:10 ` Bernd Kuhls
2014-11-17 20:35 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141117190919.GC12473@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox