Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Guido Martínez" <guido@vanguardiasur.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 5/5] package: linux-fusion: use install instead of cp
Date: Tue, 18 Nov 2014 14:17:09 -0300	[thread overview]
Message-ID: <20141118171709.GD20682@fox> (raw)
In-Reply-To: <546A714D.3040402@mind.be>

Hi Arnout, all

On Mon, Nov 17, 2014 at 11:06:05PM +0100, Arnout Vandecappelle wrote:
> On 17/11/14 18:19, Guido Mart?nez wrote:
> > in order to not depend on the previous permissions of the file
> > 
> > Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> 
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> 
>  There are a few more suspicious cp instances:
> 
> board/boundarydevices/nitrogen6x/post-build.sh
> boot/grub/grub.mk
> fs/iso9660/iso9660.mk
I'll take a look at these, thanks.

>  Also, it would be good to document somewhere (e.g. in the intro mail) why the
> rsync in the toolchain is OK. Or even better, replace it even though it's not
> really necessary - it just feels more consistent and safe.
Yes, this sounds good. Maybe use --chmod on the toolchain and add a
comment there? This way we should be covered in the future if someone
uses 'rsync -a' from there.

Cheers!

-- 
Guido Mart?nez, VanguardiaSur
www.vanguardiasur.com.ar

  reply	other threads:[~2014-11-18 17:17 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-17 17:19 [Buildroot] [PATCH v3 0/5] Target permissions Guido Martínez
2014-11-17 17:19 ` [Buildroot] [PATCH v3 1/5] Makefile: don't depend on the umask Guido Martínez
2014-11-17 21:11   ` Arnout Vandecappelle
2014-11-18 17:01     ` Guido Martínez
2014-11-18 19:22       ` Arnout Vandecappelle
2014-11-17 21:36   ` Yann E. MORIN
2014-11-17 21:41     ` Arnout Vandecappelle
2014-11-17 21:48       ` Yann E. MORIN
2014-11-17 17:19 ` [Buildroot] [PATCH v3 2/5] Makefile: don't depend on current skeleton/overlay permissions Guido Martínez
2014-11-17 21:39   ` Yann E. MORIN
2014-11-17 17:19 ` [Buildroot] [PATCH v3 3/5] pkg-generic.mk: don't depend on external package permissions Guido Martínez
2014-11-17 21:41   ` Yann E. MORIN
2014-11-18 17:02     ` Guido Martínez
2014-11-17 17:19 ` [Buildroot] [PATCH v3 4/5] package: matchbox-keyboard: use install instead of cp Guido Martínez
2014-11-17 21:44   ` Yann E. MORIN
2014-11-18 17:06     ` Guido Martínez
2014-11-17 17:19 ` [Buildroot] [PATCH v3 5/5] package: linux-fusion: " Guido Martínez
2014-11-17 21:49   ` Yann E. MORIN
2014-11-17 22:06   ` Arnout Vandecappelle
2014-11-18 17:17     ` Guido Martínez [this message]
2014-11-18 19:23       ` Arnout Vandecappelle
2014-11-18 19:40         ` Guido Martínez
2014-11-18 20:58           ` Arnout Vandecappelle
2014-11-18 22:59   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141118171709.GD20682@fox \
    --to=guido@vanguardiasur.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox