From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/4] libatomic_ops: Add host-autotools-package
Date: Tue, 18 Nov 2014 21:35:01 +0100 [thread overview]
Message-ID: <20141118203501.GI4333@free.fr> (raw)
In-Reply-To: <1415310486-25904-2-git-send-email-paguilar@paguilar.org>
Pedro, All,
Eventually, I get to review this... ;-)
On 2014-11-06 22:48 +0100, Pedro Aguilar spake thusly:
> The host-libatomic_ops is needed by host-bdwgc that is needed
> in turn by guile.
>
> bdwgc bundles its own version of libatomic_ops, but it's prefered
> to use the external one that is the default.
That sentence is not obvious for who hasn;t followed the previous
iterations of the series. Also, it is related to bdwgc, so is not
needed in that patch. Let;s just remove it.
> Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>
With the second sentence removed from the commit log:
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> ---
> Changes v1 -> v2:
> - Add host-libatomic_ops (suggested by Yann Morin)
>
> Signed-off-by: Pedro Aguilar <paguilar@paguilar.org>
That second SoB line is superfluous, and will be ignored by git.
Basically, all that is below the '---' line (included) gets ignored by
git when applying a patch.
Regards,
Yann E. MORIN.
> ---
> package/libatomic_ops/libatomic_ops.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/libatomic_ops/libatomic_ops.mk b/package/libatomic_ops/libatomic_ops.mk
> index d473901..6a26775 100644
> --- a/package/libatomic_ops/libatomic_ops.mk
> +++ b/package/libatomic_ops/libatomic_ops.mk
> @@ -20,3 +20,4 @@ LIBATOMIC_OPS_LICENSE_FILES = doc/LICENSING.txt COPYING
> LIBATOMIC_OPS_INSTALL_STAGING = YES
>
> $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-11-18 20:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 21:48 [Buildroot] [PATCH v4 0/4] package/guile: New package Pedro Aguilar
2014-11-06 21:48 ` [Buildroot] [PATCH v4 1/4] libatomic_ops: Add host-autotools-package Pedro Aguilar
2014-11-18 20:35 ` Yann E. MORIN [this message]
2014-11-06 21:48 ` [Buildroot] [PATCH v4 2/4] bdwgc: new package Pedro Aguilar
2014-11-18 20:59 ` Yann E. MORIN
2014-11-20 21:47 ` Pedro Aguilar
2014-11-23 15:23 ` Yann E. MORIN
2014-11-06 21:48 ` [Buildroot] [PATCH v4 3/4] libunistring: Add host-autotools-package Pedro Aguilar
2014-11-18 21:03 ` Yann E. MORIN
2014-11-06 21:48 ` [Buildroot] [PATCH v4 4/4] guile: new package Pedro Aguilar
2014-11-18 21:18 ` Yann E. MORIN
2014-11-20 23:02 ` Pedro Aguilar
2014-11-23 15:29 ` Yann E. MORIN
2014-11-23 19:20 ` Pedro Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118203501.GI4333@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox