From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/shairport-sync: fix init script
Date: Tue, 18 Nov 2014 23:50:16 +0100 [thread overview]
Message-ID: <20141118225016.GV4333@free.fr> (raw)
In-Reply-To: <1415833586-6181-1-git-send-email-jkrause@posteo.de>
J?rg, All,
On 2014-11-13 00:06 +0100, J?rg Krause spake thusly:
> shairport-sync uses libdaemon for running as daemon and creating the pidfile
> which conflicts with start-stop-daemons `-b -m` options. For that reason
> shairport-sync does not start using /etc/init.d/S99shairport-sync start.
>
> The issue is fixed by removing the background and pidfile task from
> start-stop-daemon and add a daemon option `-d` to shairport-sync.
>
> Signed-off-by: J?rg Krause <jkrause@posteo.de>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/shairport-sync/S99shairport-sync | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/shairport-sync/S99shairport-sync b/package/shairport-sync/S99shairport-sync
> index 31359fc..54d20ff 100644
> --- a/package/shairport-sync/S99shairport-sync
> +++ b/package/shairport-sync/S99shairport-sync
> @@ -1,12 +1,12 @@
> #! /bin/sh
>
> # Additional options that are passed to Shairport Sync
> -OPTIONS=""
> +OPTIONS="-d"
>
> case "$1" in
> start)
> echo -n "Starting shairport-sync: "
> - start-stop-daemon -S -q -m -b -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
> + start-stop-daemon -S -q -p /var/run/shairport-sync.pid --exec /usr/bin/shairport-sync -- $OPTIONS
> [ $? = 0 ] && echo "OK" || echo "FAIL"
> ;;
> stop)
> --
> 2.1.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2014-11-18 22:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 23:06 [Buildroot] [PATCH 1/1] package/shairport-sync: fix init script Jörg Krause
2014-11-18 22:50 ` Yann E. MORIN [this message]
2014-11-19 21:50 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141118225016.GV4333@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox