Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/openssl: Enable parallel build
Date: Tue, 18 Nov 2014 22:55:25 +0100	[thread overview]
Message-ID: <20141118225525.6e8b4e02@free-electrons.com> (raw)
In-Reply-To: <1416146446-27060-1-git-send-email-bernd.kuhls@t-online.de>

Dear Bernd Kuhls,

On Sun, 16 Nov 2014 15:00:45 +0100, Bernd Kuhls wrote:
> Patch taken from Gentoo, tested 50+ times on buildroot with make -j80.
> 
> Comparison of compile duration:
> 
> make -j1
> real    1m24.464s
> user    1m8.620s
> sys     0m9.661s
> 
> make -j80
> real    0m27.774s
> user    1m34.234s
> sys     0m13.441s
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/openssl/openssl-005-parallel-build.patch |  363 ++++++++++++++++++++++
>  package/openssl/openssl.mk                       |   10 +-
>  2 files changed, 368 insertions(+), 5 deletions(-)
>  create mode 100644 package/openssl/openssl-005-parallel-build.patch

Unfortunately, this patch is a fairly large patch, which is more a
feature patch than a real fix. Could we instead get it merged upstream?

I discussed this with Yann, and I believe Peter will agree that it's a
feature patch that we shouldn't take in Buildroot. The solutions are
either to take this patch upstream, or in Buildroot build in parallel
and then fallback to serial build if the parallel build has failed.
Something along the lines of:

	$(MAKE) -C $(@D) || $(MAKE1) -C $(@D)

(Suggested by Yann).

So I'll mark this patch as rejected in patchwork.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2014-11-18 21:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-16 14:00 [Buildroot] [PATCH 1/2] package/openssl: Enable parallel build Bernd Kuhls
2014-11-16 14:00 ` [Buildroot] [PATCH 2/2] package/openssl: rename patches to the new convention Bernd Kuhls
2014-11-18 22:38   ` Thomas Petazzoni
2014-11-18 21:55 ` Thomas Petazzoni [this message]
2014-11-18 22:01   ` [Buildroot] [PATCH 1/2] package/openssl: Enable parallel build Peter Korsgaard
2015-03-08  2:31   ` Mike Frysinger
2015-03-08  7:13     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141118225525.6e8b4e02@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox