From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] live555: add support for building dynamic libraries
Date: Wed, 19 Nov 2014 10:03:38 +0100 [thread overview]
Message-ID: <20141119100338.6daa56b0@free-electrons.com> (raw)
In-Reply-To: <20141119055402.GA2374@sapphire.tkos.co.il>
Dear Baruch Siach,
On Wed, 19 Nov 2014 07:54:02 +0200, Baruch Siach wrote:
> > I don't understand why you need a separate config.linux and
> > config.linux-with-shared-libraries. Since in Buildroot we will either
> > be building with BR2_PREFER_STATIC_LIB=y, or BR2_PREFER_STATIC_LIB
> > disabled, why not simply call the file config.linux, as it was called
> > before this patch?
> >
> > Of course, the LIVE555_LIBRARY_LINK think is needed, but I don't see
> > why the other changes are needed.
> >
> > Can you expand on this?
>
> Both config.linux and config.linux-with-shared-libraries already exist in
> upstream code. We are only appending to these files to override some
> variables. The linux-with-shared-libraries variant defines a few additional
> variables needed for dynamic linking (library version, installation target).
> Aligning to upstream build procedure should be more future proof, IMO.
Thanks for the explanation, definitely makes sense. I've added part of
this paragraph of explanation to the commit log, and then applied both
this patch, as well as the patch that allows VLC to link dynamically
against live555 to the next branch.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-11-19 9:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 8:18 [Buildroot] [PATCH 1/3] live555: use upstream install target for staging installation Baruch Siach
2014-11-17 8:18 ` [Buildroot] [PATCH 2/3] live555: add support for building dynamic libraries Baruch Siach
2014-11-18 22:17 ` Thomas Petazzoni
2014-11-19 5:54 ` Baruch Siach
2014-11-19 9:03 ` Thomas Petazzoni [this message]
2014-11-17 8:18 ` [Buildroot] [PATCH 3/3] vlc: allow dynamically linking live555 Baruch Siach
2014-11-18 22:15 ` [Buildroot] [PATCH 1/3] live555: use upstream install target for staging installation Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141119100338.6daa56b0@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox