Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 8/9] manual: Harmonize command example
Date: Wed, 19 Nov 2014 23:32:48 +0100	[thread overview]
Message-ID: <20141119223248.GJ3779@free.fr> (raw)
In-Reply-To: <1416068964-22529-8-git-send-email-maxime.hadjinlian@gmail.com>

Maxime, All,

On 2014-11-15 17:29 +0100, Maxime Hadjinlian spake thusly:
> To facilitate copy/paste for manual's reader, remove anything before
> command example.
> 
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>

Ditto: I'd have preferred we keep a leading $. Still, for the same
reasons as the previous patch:
-- Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

But see below...

> ---
>  docs/manual/customize-outside-br.txt | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/docs/manual/customize-outside-br.txt b/docs/manual/customize-outside-br.txt
> index 5d63e60..2b01433 100644
> --- a/docs/manual/customize-outside-br.txt
> +++ b/docs/manual/customize-outside-br.txt
> @@ -30,30 +30,30 @@ but if it's passed as a relative path, it is important to note that it
>  is interpreted relative to the main Buildroot source directory, *not*
>  to the Buildroot output directory.
>  
> -Some examples:
> +Some examples, assuming you are inside the main Buildroot source directory:
>  
>  -----
> - buildroot/ $ make BR2_EXTERNAL=/path/to/foobar menuconfig
> +make BR2_EXTERNAL=/path/to/foobar menuconfig
>  -----
>  
>  From now on, external definitions from the +/path/to/foobar+
>  directory will be used:
>  
>  -----
> - buildroot/ $ make
> - buildroot/ $ make legal-info
> +make
> +make legal-info
>  -----
>  
>  We can switch to another external definitions directory at any time:
>  
>  -----
> - buildroot/ $ make BR2_EXTERNAL=/where/we/have/barfoo xconfig
> +make BR2_EXTERNAL=/where/we/have/barfoo xconfig
>  -----
>  
>  Or disable the usage of external definitions:

Not your fault, but: s/usage/use/

Regards,
Yann E. MORIN.

>  -----
> - buildroot/ $ make BR2_EXTERNAL= xconfig
> +make BR2_EXTERNAL= xconfig
>  -----
>  
>  +BR2_EXTERNAL+ allows three different things:
> -- 
> 2.1.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2014-11-19 22:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-15 16:29 [Buildroot] [PATCH 1/9] package/*/*.mk: Fix indent Maxime Hadjinlian
2014-11-15 16:29 ` [Buildroot] [PATCH 2/9] makedevs: Rework README Maxime Hadjinlian
2014-11-19 22:05   ` Yann E. MORIN
2014-11-24  9:34     ` Maxime Hadjinlian
2014-11-15 16:29 ` [Buildroot] [PATCH 3/9] manual: Rework makedevs syntax Maxime Hadjinlian
2014-11-19 22:14   ` Yann E. MORIN
2014-11-22 19:15   ` Thomas Petazzoni
2014-11-15 16:29 ` [Buildroot] [PATCH 4/9] manual: Remove trailing space Maxime Hadjinlian
2014-11-19 22:15   ` Yann E. MORIN
2014-11-22 19:15   ` Thomas Petazzoni
2014-11-15 16:29 ` [Buildroot] [PATCH 5/9] manual: Add missing vim header Maxime Hadjinlian
2014-11-19 22:17   ` Yann E. MORIN
2014-11-22 19:15   ` Thomas Petazzoni
2014-11-15 16:29 ` [Buildroot] [PATCH 6/9] manual: Add newline before block code Maxime Hadjinlian
2014-11-19 22:21   ` Yann E. MORIN
2014-11-22 19:15   ` Thomas Petazzoni
2014-11-15 16:29 ` [Buildroot] [PATCH 7/9] manual: Remove dollar before command example Maxime Hadjinlian
2014-11-19 22:29   ` Yann E. MORIN
2014-11-22 19:16   ` Thomas Petazzoni
2014-11-24  8:14     ` Maxime Hadjinlian
2014-11-15 16:29 ` [Buildroot] [PATCH 8/9] manual: Harmonize " Maxime Hadjinlian
2014-11-19 22:32   ` Yann E. MORIN [this message]
2014-11-15 16:29 ` [Buildroot] [PATCH 9/9] manual: Block code needs only 4 dashes Maxime Hadjinlian
2014-11-19 22:37   ` Yann E. MORIN
2014-11-22 19:16   ` Thomas Petazzoni
2014-11-19 22:10 ` [Buildroot] [PATCH 1/9] package/*/*.mk: Fix indent Yann E. MORIN
2014-11-19 22:25 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141119223248.GJ3779@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox