Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next v2] python-certifi: add new package
Date: Sat, 22 Nov 2014 20:59:00 +0100	[thread overview]
Message-ID: <20141122205900.5aa98365@free-electrons.com> (raw)
In-Reply-To: <20141122185640.GE4295@free.fr>

Dear Yann E. MORIN,

On Sat, 22 Nov 2014 19:56:40 +0100, Yann E. MORIN wrote:

> > > sha1   f53dc8f57aaf6d69c183ebadcec52ece0a55cc3f                         certifi-14.05.14.tar.gz
> > > sha256 1e1bcbacd6357c151ae37cf0290dcc809721d32ce21fd6b7339568f3ddef1b69 certifi-14.05.14.tar.gz
> > 
> > Why do we suggest to have two hashes? Isn't sha265 sufficient?
> 
> As Gustavo said, that's because sha1 and sha256 are two different hash
> mechanisms, and it's better to have both.
> 
> So I was following his advice, even though I don't mind adding just the
> sha256.

Hum. We need some decision here :)

> > Also, is it necessary to align the different columns? Should it be done
> > with tabs or spaces? I've seen different solutions being used.
> 
> I don't mind not aligning the fields, though I find it more convenient
> to read if they are.
> 
> If they get aligned, I think we should use spaces; tabs do not help
> because people may have different tabwidths.
> 
> Also, aligning with spaces is what we are doing for _PREMISSIONS and
> _USERS, so I think that's OK to align.
> 
> Also, the manual states:
> 
>     Note: the number of spaces does not matter, so one can use spaces to
>     properly align the different fields.

And Peter, when reviewing the scancpan script, which did align things
with spaces, was wondering why the script was doing this weird
indentation.

We also need some decision here :-)

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-11-22 19:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-22  9:46 [Buildroot] [PATCH next v2] python-certifi: add new package Yegor Yefremov
2014-11-22 17:09 ` Yann E. MORIN
2014-11-22 18:08   ` Thomas Petazzoni
2014-11-22 18:56     ` Yann E. MORIN
2014-11-22 19:59       ` Thomas Petazzoni [this message]
2014-11-22 20:16         ` Yegor Yefremov
2014-11-22 20:24           ` Thomas Petazzoni
2014-11-22 20:32             ` Yegor Yefremov
2014-11-22 20:44               ` Thomas Petazzoni
2014-11-24 22:01         ` Peter Korsgaard
2014-11-22 17:15 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141122205900.5aa98365@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox